Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Unified Diff: third_party/WebKit/Source/web/ContextMenuClientImpl.cpp

Issue 2855353002: Make Paste Popup use selection rect for positioning (Closed)
Patch Set: Calculate selection rect better Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | third_party/WebKit/public/web/WebContextMenuData.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/ContextMenuClientImpl.cpp
diff --git a/third_party/WebKit/Source/web/ContextMenuClientImpl.cpp b/third_party/WebKit/Source/web/ContextMenuClientImpl.cpp
index f5151fa215c236921294a946d95afa6d4661da0d..e41d8f27d37bec19b2785e70eaa3d1149111b645 100644
--- a/third_party/WebKit/Source/web/ContextMenuClientImpl.cpp
+++ b/third_party/WebKit/Source/web/ContextMenuClientImpl.cpp
@@ -402,6 +402,16 @@ bool ContextMenuClientImpl::ShowContextMenu(const ContextMenu* default_menu,
data.input_field_type = WebContextMenuData::kInputFieldTypeNone;
}
+ if (data.selected_text.IsEmpty()) {
aelias_OOO_until_Jul13 2017/05/11 21:16:17 Please push this logic down into FrameSelection::B
+ WebRect focus_webrect;
+ WebRect anchor_webrect;
+ web_view_->SelectionBounds(focus_webrect, anchor_webrect);
+ data.selection_rect = focus_webrect;
+ } else {
+ data.selection_rect = selected_frame->View()->ContentsToViewport(
+ web_view_->MainFrame()->SelectionBoundsRect());
+ }
+
if (from_touch && !ShouldShowContextMenuFromTouch(data))
return false;
« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | third_party/WebKit/public/web/WebContextMenuData.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698