Make Paste Popup use selection rect for positioning

third_party/WebKit/Source/web/ContextMenuClientImpl.cpp

 /*
  * Copyright (C) 2009, 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 384 matching lines @@
     if (element->type() == InputTypeNames::password)
       data.input_field_type = WebContextMenuData::kInputFieldTypePassword;
     else if (element->IsTextField())
       data.input_field_type = WebContextMenuData::kInputFieldTypePlainText;
     else
       data.input_field_type = WebContextMenuData::kInputFieldTypeOther;
   } else {
     data.input_field_type = WebContextMenuData::kInputFieldTypeNone;
   }
 
+  if (data.selected_text.IsEmpty()) {

[aelias_OOO_until_Jul13, 2017/05/11 21:16:17]

Please push this logic down into FrameSelection::Bounds(), or if there's a
problem with that, at least SelectionBoundsRect() (which has no other
callsites).

+    WebRect focus_webrect;
+    WebRect anchor_webrect;
+    web_view_->SelectionBounds(focus_webrect, anchor_webrect);
+    data.selection_rect = focus_webrect;
+  } else {
+    data.selection_rect = selected_frame->View()->ContentsToViewport(
+        web_view_->MainFrame()->SelectionBoundsRect());
+  }
+
   if (from_touch && !ShouldShowContextMenuFromTouch(data))
     return false;
 
   selected_web_frame->SetContextMenuNode(r.InnerNodeOrImageMapImage());
   if (!selected_web_frame->Client())
     return false;
 
   selected_web_frame->Client()->ShowContextMenu(data);
   return true;
 }
@@ skipping 51 matching lines @@
   sub_menu_items.Swap(output_items);
 }
 
 void ContextMenuClientImpl::PopulateCustomMenuItems(
     const ContextMenu* default_menu,
     WebContextMenuData* data) {
   PopulateSubMenuItems(default_menu->Items(), data->custom_items);
 }
 
 }  // namespace blink