Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 2855323005: OOPIFs: Tweaking test expectations for http/tests/inspector layout tests. (Closed)

Created:
3 years, 7 months ago by Łukasz Anforowicz
Modified:
3 years, 7 months ago
Reviewers:
alexmos
CC:
chromium-reviews, blink-reviews, Charlie Reis, kozy
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

OOPIFs: Tweaking test expectations for http/tests/inspector layout tests. This CL tweaks test expectations for http/tests/inspector layout tests, to account for work that went into making DevTools support OOPIFs. These tests used to timeout but now are passing fine: http/tests/inspector/change-iframe-src.html virtual/mojo-loading/http/tests/inspector/change-iframe-src.html These tests expected a timeout but not are failing with a text diff (tracked by https://crbug.com/718940): http/tests/inspector/console-cross-origin-iframe-logging.html virtual/mojo-loading/http/tests/inspector/console-cross-origin-iframe-logging.html These tests are intermittently timing out locally and on Site Isolation Win FYI bot: http/tests/inspector-protocol/request-referrer-policy.html virtual/mojo-loading/http/tests/inspector-protocol/request-referrer-policy.html BUG=718940, 623268 NOTRY=true TEST=Run 10 times all http/tests/inspector tests covered by the expectations file. Review-Url: https://codereview.chromium.org/2855323005 Cr-Commit-Position: refs/heads/master@{#469730} Committed: https://chromium.googlesource.com/chromium/src/+/9a1b65feb44e32a48ad7fb51384fa868bc864008

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/site-per-process View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Łukasz Anforowicz
alexmos@, can you PTAL?
3 years, 7 months ago (2017-05-05 17:43:35 UTC) #2
Łukasz Anforowicz
+kozyatinskiy@ and +creis@ to CC - FYI
3 years, 7 months ago (2017-05-05 17:44:41 UTC) #3
alexmos
LGTM
3 years, 7 months ago (2017-05-05 18:16:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2855323005/1
3 years, 7 months ago (2017-05-05 18:20:14 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-05 18:28:45 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9a1b65feb44e32a48ad7fb51384f...

Powered by Google App Engine
This is Rietveld 408576698