Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2855303004: Trivial renames in preparation for Web Manifest support (Closed)

Created:
3 years, 7 months ago by mastiz
Modified:
3 years, 7 months ago
Reviewers:
pkotwicz
CC:
chromium-reviews, jam, ios-reviews+web_chromium.org, darin-cc_chromium.org, Eugene But (OOO till 7-30), ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Trivial renames in preparation for Web Manifest support These trivial changes have been split from a follow-up CL that extends FaviconHandler with support for Web Manifests. BUG=690383 Review-Url: https://codereview.chromium.org/2855303004 Cr-Commit-Position: refs/heads/master@{#471313} Committed: https://chromium.googlesource.com/chromium/src/+/6d29b2b574b2c85043ef6953a3edb9f04c86ed58

Patch Set 1 #

Patch Set 2 : More changes. #

Patch Set 3 : Rebased. #

Patch Set 4 : Rebased. #

Patch Set 5 : Rebased. #

Patch Set 6 : Rebased on top of patch. #

Patch Set 7 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -88 lines) Patch
M components/favicon/content/content_favicon_driver.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/favicon/core/favicon_driver_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M components/favicon/core/favicon_driver_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/favicon/core/favicon_handler.h View 1 2 4 chunks +6 lines, -6 lines 0 comments Download
M components/favicon/core/favicon_handler.cc View 1 2 11 chunks +27 lines, -23 lines 0 comments Download
M components/favicon/core/favicon_handler_unittest.cc View 1 2 3 29 chunks +63 lines, -54 lines 0 comments Download
M components/favicon/ios/web_favicon_driver.mm View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 19 (15 generated)
mastiz
Another piece split from https://codereview.chromium.org/2799273002/. For this one, it probably makes sense to land it ...
3 years, 7 months ago (2017-05-05 08:54:59 UTC) #4
pkotwicz
LGTM
3 years, 7 months ago (2017-05-05 18:25:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2855303004/120001
3 years, 7 months ago (2017-05-12 13:32:11 UTC) #16
commit-bot: I haz the power
3 years, 7 months ago (2017-05-12 15:41:54 UTC) #19
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/6d29b2b574b2c85043ef6953a3ed...

Powered by Google App Engine
This is Rietveld 408576698