Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Issue 2855303003: Mojo C++ bindings: add a MakeRequest overload that binds InterfacePtrInfo. (Closed)

Created:
3 years, 7 months ago by yzshen1
Modified:
3 years, 7 months ago
Reviewers:
jam
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: add a MakeRequest overload that binds InterfacePtrInfo. BUG=None Review-Url: https://codereview.chromium.org/2855303003 Cr-Commit-Position: refs/heads/master@{#469448} Committed: https://chromium.googlesource.com/chromium/src/+/3618dd3427458c36cd1d912181911799ce6e6504

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -7 lines) Patch
M mojo/public/cpp/bindings/interface_ptr.h View 1 chunk +4 lines, -4 lines 0 comments Download
M mojo/public/cpp/bindings/interface_request.h View 2 chunks +16 lines, -0 lines 0 comments Download
M mojo/public/cpp/bindings/tests/interface_ptr_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
yzshen1
Hi, John. Would you please take a look? Thanks!
3 years, 7 months ago (2017-05-04 18:35:25 UTC) #4
jam
lgtm
3 years, 7 months ago (2017-05-04 20:21:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2855303003/1
3 years, 7 months ago (2017-05-04 20:22:39 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 20:28:17 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3618dd3427458c36cd1d91218191...

Powered by Google App Engine
This is Rietveld 408576698