Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2855293002:
More tests for UrlUtilities#isValidForIntentFallbackNavigation. (Closed)
DescriptionMore tests for UrlUtilities#isValidForIntentFallbackNavigation.
I stumbled on isValidForIntentFallbackNavigation and found that having this
more verbose tests would make it easier for me to understand what I can expect
from this method, without having to trace down its implementation.
Not feeling strongly, but I think these are worth adding.
BUG=
Review-Url: https://codereview.chromium.org/2855293002
Cr-Commit-Position: refs/heads/master@{#469567}
Committed: https://chromium.googlesource.com/chromium/src/+/27cd342cd4d1adf5690be47b7c80b83122b1d9bd
Patch Set 1 : Initial patch #
Messages
Total messages: 21 (15 generated)
The CQ bit was checked by piotrs@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by piotrs@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Patchset #1 (id:1) has been deleted
Patchset #2 (id:40001) has been deleted
piotrs@chromium.org changed reviewers: + yusufo@chromium.org
Just a small follow-up from codereview.chromium.org/2829943002.
lgtm but you will need an OWNERS approval
piotrs@chromium.org changed reviewers: + tedchoc@chromium.org
Hi Ted, can you take a look at this super small change?
lgtm
The CQ bit was checked by piotrs@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493945410279280,
"parent_rev": "8976caef37205d31c6b73aec7f008a652671f076", "commit_rev":
"27cd342cd4d1adf5690be47b7c80b83122b1d9bd"}
Message was sent while issue was closed.
Description was changed from ========== More tests for UrlUtilities#isValidForIntentFallbackNavigation. I stumbled on isValidForIntentFallbackNavigation and found that having this more verbose tests would make it easier for me to understand what I can expect from this method, without having to trace down its implementation. Not feeling strongly, but I think these are worth adding. BUG= ========== to ========== More tests for UrlUtilities#isValidForIntentFallbackNavigation. I stumbled on isValidForIntentFallbackNavigation and found that having this more verbose tests would make it easier for me to understand what I can expect from this method, without having to trace down its implementation. Not feeling strongly, but I think these are worth adding. BUG= Review-Url: https://codereview.chromium.org/2855293002 Cr-Commit-Position: refs/heads/master@{#469567} Committed: https://chromium.googlesource.com/chromium/src/+/27cd342cd4d1adf5690be47b7c80... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as https://chromium.googlesource.com/chromium/src/+/27cd342cd4d1adf5690be47b7c80... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
