chrome/browser/resources/settings/search_engines_page/search_engines_list.js - Issue 2855273002: Make fixed size scrolling more like other lists.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/search_engines_page/search_engines_list.js

Issue 2855273002: Make fixed size scrolling more like other lists. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/search_engines_page/search_engines_list.html ('k') | chrome/browser/resources/settings/settings_shared_css.html » ('j') | chrome/browser/resources/settings/settings_shared_css.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/search_engines_page/search_engines_list.js

diff --git a/chrome/browser/resources/settings/search_engines_page/search_engines_list.js b/chrome/browser/resources/settings/search_engines_page/search_engines_list.js

index 4134688459165f054b3534aaffa9864e0be18fd1..ce196cff3ba17de163c5a64b57c22b7a1c4274da 100644

--- a/chrome/browser/resources/settings/search_engines_page/search_engines_list.js

+++ b/chrome/browser/resources/settings/search_engines_page/search_engines_list.js

@@ -36,7 +36,15 @@ Polymer({

* Fix height of list if no scrollTarget is present.

* @return {string}

- getIronListClass_: function() {

+ getHeightClass: function() {

return this.scrollTarget ? '' : 'fixed-height-list';

+ /**

+ * Only scroll when no target is set.

+ * @return {boolean}

+ */

+ isScrollable: function() {

+ return !this.scrollTarget;

+ },

});