chrome/browser/resources/settings/search_engines_page/search_engines_list.html - Issue 2855273002: Make fixed size scrolling more like other lists.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/search_engines_page/search_engines_list.html

Issue 2855273002: Make fixed size scrolling more like other lists. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/resources/settings/search_engines_page/search_engines_list.js » ('j') | chrome/browser/resources/settings/settings_shared_css.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/search_engines_page/search_engines_list.html

diff --git a/chrome/browser/resources/settings/search_engines_page/search_engines_list.html b/chrome/browser/resources/settings/search_engines_page/search_engines_list.html

index 04c9a28a3c5f14387a3e180bd82f8d6ffc4e2cf6..2881e69b7472c01b1b42b3c5e76763a8b374dea8 100644

--- a/chrome/browser/resources/settings/search_engines_page/search_engines_list.html

+++ b/chrome/browser/resources/settings/search_engines_page/search_engines_list.html

@@ -44,9 +44,10 @@

<div class="url">$i18n{searchEnginesQueryURL}</div>

</div>

- <div id="container" class="scroll-container">

+ <div id="container"

+ class$="scroll-container [[getHeightClass(scrollTarget)]]"

+ scrollable$="[[isScrollable(scrollTarget)]]">

<iron-list items="[[engines]]" scroll-target="[[scrollTarget]]"

- class$="[[getIronListClass_(scrollTarget)]]"

scroll-offset="[[scrollOffset]]">

<settings-search-engine-entry engine="[[item]]"