Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp

Issue 2855263004: Throw in window.open() when an invalid URL is being passed (Closed)
Patch Set: updates Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp b/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp
index fbde86903d45695683a767a9ff69c3dea2edf087..53587f3febcc8c66405f285af4baa750f624ba05 100644
--- a/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp
@@ -287,7 +287,11 @@ void V8Window::openMethodCustom(
// passed the BindingSecurity check above.
DOMWindow* opened_window = ToLocalDOMWindow(impl)->open(
url_string, frame_name, window_features_string,
- CurrentDOMWindow(info.GetIsolate()), EnteredDOMWindow(info.GetIsolate()));
+ CurrentDOMWindow(info.GetIsolate()), EnteredDOMWindow(info.GetIsolate()),
+ exception_state);
+ if (exception_state.HadException()) {
+ return;
+ }
if (!opened_window) {
V8SetReturnValueNull(info);
return;

Powered by Google App Engine
This is Rietveld 408576698