Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 2855223002: Use constexpr TaskTraits constructor in components. (Closed)

Created:
3 years, 7 months ago by fdoray
Modified:
3 years, 7 months ago
Reviewers:
gab, sdefresne
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use constexpr TaskTraits constructor in components. Use a constexpr constructor that accepts traits in any order instead of the builder pattern to construct TaskTraits in components. BUG=713683 R=gab@chromium.org TBR=sdefresne@chromium.org Review-Url: https://codereview.chromium.org/2855223002 Cr-Commit-Position: refs/heads/master@{#469135} Committed: https://chromium.googlesource.com/chromium/src/+/61b89c802236da47eb1fc17fdc34c2c66f843d30

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -52 lines) Patch
M components/history/core/browser/history_service.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M components/leveldb/env_mojo.cc View 1 chunk +4 lines, -7 lines 0 comments Download
M components/nacl/browser/nacl_browser.cc View 1 chunk +1 line, -3 lines 0 comments Download
M components/nacl/browser/nacl_file_host.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/nacl/browser/nacl_host_message_filter.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M components/nacl/browser/nacl_process_host.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M components/nacl/browser/pnacl_host.cc View 3 chunks +4 lines, -11 lines 0 comments Download
M components/translate/core/browser/ranker_model_loader.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M components/wallpaper/wallpaper_manager_base.cc View 1 chunk +4 lines, -7 lines 0 comments Download
M components/web_restrictions/browser/web_restrictions_client.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
fdoray
3 years, 7 months ago (2017-05-03 20:20:39 UTC) #1
fdoray
gab@: PTAL The change will then be TBRed to the owner.
3 years, 7 months ago (2017-05-03 20:20:42 UTC) #3
gab
lgtm
3 years, 7 months ago (2017-05-03 20:38:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2855223002/1
3 years, 7 months ago (2017-05-03 20:43:59 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/61b89c802236da47eb1fc17fdc34c2c66f843d30
3 years, 7 months ago (2017-05-03 21:35:30 UTC) #11
sdefresne
3 years, 7 months ago (2017-05-04 12:40:19 UTC) #12
Message was sent while issue was closed.
rs lgtm

Powered by Google App Engine
This is Rietveld 408576698