Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 2855183002: Use the form sheet presentation style for the Payment UI. (Closed)

Created:
3 years, 7 months ago by macourteau
Modified:
3 years, 7 months ago
Reviewers:
lpromero
CC:
chromium-reviews, marq+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use the form sheet presentation style for the Payment UI. This makes the UI consistent with the settings UI. Screenshots: before: http://imgur.com/cze5exI after: http://imgur.com/1Z43yGW BUG=602666 Review-Url: https://codereview.chromium.org/2855183002 Cr-Commit-Position: refs/heads/master@{#469298} Committed: https://chromium.googlesource.com/chromium/src/+/3d438e8881839675679519a30b4fa9afe9d5c52f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M ios/chrome/browser/ui/payments/payment_request_coordinator.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
macourteau
3 years, 7 months ago (2017-05-03 18:56:41 UTC) #3
lpromero
lgtm
3 years, 7 months ago (2017-05-04 09:29:27 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2855183002/1
3 years, 7 months ago (2017-05-04 09:29:38 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 09:33:21 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3d438e8881839675679519a30b4f...

Powered by Google App Engine
This is Rietveld 408576698