Implements a display scale tray setting behind a chrome switch

Implements a display scale tray setting behind a chrome switch

Implements a system tray setting to update and force a device scale factor
on the device. This tray setting is hidden behind a switch. This will help in debugging and testing UI at different scales faster.

Also adds a utility method to display class to force a new device scale
factor.

COMPONENT=System Tray, Ash switches, Ash strings, about flags, display
BUG=718639
Review-Url: https://codereview.chromium.org/2855143004
Cr-Commit-Position: refs/heads/master@{#470531}
Committed: https://chromium.googlesource.com/chromium/src/+/49cd16f6b9d7512e5cbcc02b41434d8e6cfe7134

[malaykeshav, 2017-05-04 23:01:27]

The CQ bit was checked by malaykeshav@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-04 23:02:28]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[malaykeshav, 2017-05-05 01:25:56]

Patchset #1 (id:1) has been deleted

[malaykeshav, 2017-05-05 01:26:02]

The CQ bit was checked by malaykeshav@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-05 01:26:27]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 02:06:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-05 02:06:25]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[malaykeshav, 2017-05-05 19:13:24]

The CQ bit was checked by malaykeshav@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-05 19:14:22]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 19:19:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-05 19:19:53]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[malaykeshav, 2017-05-05 20:04:48]

Patchset #4 (id:80001) has been deleted

[malaykeshav, 2017-05-05 20:04:56]

The CQ bit was checked by malaykeshav@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-05 20:05:52]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[malaykeshav, 2017-05-05 20:44:47]

malaykeshav@chromium.org changed reviewers:
+ oshima@chromium.org

[malaykeshav, 2017-05-05 20:44:48]

PTAL

[commit-bot: I haz the power, 2017-05-05 23:14:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-05 23:14:02]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[oshima, 2017-05-06 19:50:23]

https://codereview.chromium.org/2855143004/diff/100001/ash/system/display_sca...
File ash/system/display_scale/scale_detailed_view.cc (right):

https://codereview.chromium.org/2855143004/diff/100001/ash/system/display_sca...
ash/system/display_scale/scale_detailed_view.cc:61: view_to_scale_[container] =
scale;
optional: or you can parse it from the view.

https://codereview.chromium.org/2855143004/diff/100001/ash/system/display_sca...
File ash/system/display_scale/scale_view.cc (right):

https://codereview.chromium.org/2855143004/diff/100001/ash/system/display_sca...
ash/system/display_scale/scale_view.cc:1: 
ditto

https://codereview.chromium.org/2855143004/diff/100001/ash/system/display_sca...
ash/system/display_scale/scale_view.cc:39: return str_value;
can you use StringPrintf instead?

https://codereview.chromium.org/2855143004/diff/100001/ash/system/display_sca...
File ash/system/display_scale/scale_view.h (right):

https://codereview.chromium.org/2855143004/diff/100001/ash/system/display_sca...
ash/system/display_scale/scale_view.h:2: 
nit: remove empty lines

https://codereview.chromium.org/2855143004/diff/100001/ash/system/display_sca...
File ash/system/display_scale/tray_scale.cc (right):

https://codereview.chromium.org/2855143004/diff/100001/ash/system/display_sca...
ash/system/display_scale/tray_scale.cc:1: 
ditto

https://codereview.chromium.org/2855143004/diff/100001/ash/system/display_sca...
ash/system/display_scale/tray_scale.cc:2: // Copyright 2014 The Chromium
Authors. All rights reserved.
2017

https://codereview.chromium.org/2855143004/diff/100001/ash/system/display_sca...
File ash/system/display_scale/tray_scale.h (right):

https://codereview.chromium.org/2855143004/diff/100001/ash/system/display_sca...
ash/system/display_scale/tray_scale.h:1: 
ditto

https://codereview.chromium.org/2855143004/diff/100001/ash/system/display_sca...
ash/system/display_scale/tray_scale.h:19: }
// tray

and space

https://codereview.chromium.org/2855143004/diff/100001/chrome/browser/about_f...
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/2855143004/diff/100001/chrome/browser/about_f...
chrome/browser/about_flags.cc:2852: #endif
I prefer not to expose this to users.
Rather we should hook up with the UI scale.

[malaykeshav, 2017-05-08 19:17:55]

The CQ bit was checked by malaykeshav@chromium.org to run a CQ dry run

[malaykeshav, 2017-05-08 19:18:07]

https://codereview.chromium.org/2855143004/diff/100001/ash/system/display_sca...
File ash/system/display_scale/scale_detailed_view.cc (right):

https://codereview.chromium.org/2855143004/diff/100001/ash/system/display_sca...
ash/system/display_scale/scale_detailed_view.cc:61: view_to_scale_[container] =
scale;
On 2017/05/06 at 19:50:22, oshima wrote:
> optional: or you can parse it from the view.

Ack

https://codereview.chromium.org/2855143004/diff/100001/ash/system/display_sca...
File ash/system/display_scale/scale_view.cc (right):

https://codereview.chromium.org/2855143004/diff/100001/ash/system/display_sca...
ash/system/display_scale/scale_view.cc:1: 
On 2017/05/06 at 19:50:22, oshima wrote:
> ditto

Done

https://codereview.chromium.org/2855143004/diff/100001/ash/system/display_sca...
ash/system/display_scale/scale_view.cc:39: return str_value;
On 2017/05/06 at 19:50:22, oshima wrote:
> can you use StringPrintf instead?

Done

https://codereview.chromium.org/2855143004/diff/100001/ash/system/display_sca...
File ash/system/display_scale/scale_view.h (right):

https://codereview.chromium.org/2855143004/diff/100001/ash/system/display_sca...
ash/system/display_scale/scale_view.h:2: 
On 2017/05/06 at 19:50:22, oshima wrote:
> nit: remove empty lines

Done

https://codereview.chromium.org/2855143004/diff/100001/ash/system/display_sca...
File ash/system/display_scale/tray_scale.cc (right):

https://codereview.chromium.org/2855143004/diff/100001/ash/system/display_sca...
ash/system/display_scale/tray_scale.cc:1: 
On 2017/05/06 at 19:50:22, oshima wrote:
> ditto

Done

https://codereview.chromium.org/2855143004/diff/100001/ash/system/display_sca...
ash/system/display_scale/tray_scale.cc:2: // Copyright 2014 The Chromium
Authors. All rights reserved.
On 2017/05/06 at 19:50:22, oshima wrote:
> 2017

Done

https://codereview.chromium.org/2855143004/diff/100001/ash/system/display_sca...
File ash/system/display_scale/tray_scale.h (right):

https://codereview.chromium.org/2855143004/diff/100001/ash/system/display_sca...
ash/system/display_scale/tray_scale.h:1: 
On 2017/05/06 at 19:50:22, oshima wrote:
> ditto

Done

https://codereview.chromium.org/2855143004/diff/100001/ash/system/display_sca...
ash/system/display_scale/tray_scale.h:19: }
On 2017/05/06 at 19:50:22, oshima wrote:
> // tray
> 
> and space

Done

"space"?

[commit-bot: I haz the power, 2017-05-08 19:18:41]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 19:58:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 19:58:09]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[malaykeshav, 2017-05-08 22:58:20]

The CQ bit was checked by malaykeshav@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-08 23:07:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 01:04:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 01:04:45]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[malaykeshav, 2017-05-09 01:32:41]

The CQ bit was checked by malaykeshav@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-09 01:35:09]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[oshima, 2017-05-09 03:58:21]

https://codereview.chromium.org/2855143004/diff/160001/ash/system/display_sca...
File ash/system/display_scale/scale_view.cc (right):

https://codereview.chromium.org/2855143004/diff/160001/ash/system/display_sca...
ash/system/display_scale/scale_view.cc:88: if (reason ==
views::VALUE_CHANGED_BY_USER)
nit: {}

https://codereview.chromium.org/2855143004/diff/160001/ui/display/display.cc
File ui/display/display.cc (right):

https://codereview.chromium.org/2855143004/diff/160001/ui/display/display.cc#...
ui/display/display.cc:97: g_forced_device_scale_factor = -1.0;
I somehow missed this change in the first review.

Just setting g_forced_device_scale_factor, g_has_forced_device_scale_factor
didn't work?

[commit-bot: I haz the power, 2017-05-09 05:04:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 05:04:12]

Dry run: This issue passed the CQ dry run.

[oshima, 2017-05-09 05:22:40]

and I assume you don't need histogram change?

[malaykeshav, 2017-05-09 17:51:54]

The CQ bit was checked by malaykeshav@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-09 17:53:13]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 18:49:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 18:49:32]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[malaykeshav, 2017-05-09 21:51:19]

The CQ bit was checked by malaykeshav@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-09 21:52:34]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[malaykeshav, 2017-05-09 22:08:43]

Description was changed from

==========
Implements a display scale tray setting behind a chrome flag

Implements a system tray setting to update and force a device scale factor
on the device. This tray setting is hidden behind a switch and chrome
flag. This will help in debugging and testing UI at different scales
faster.

Also adds a utility method to display class to force a new device scale
factor.

COMPONENT=System Tray, Ash switches, Ash strings, about flags, display
BUG=718639
==========

to

==========
Implements a display scale tray setting behind a chrome switch

Implements a system tray setting to update and force a device scale factor
on the device. This tray setting is hidden behind a switch. This will help in
debugging and testing UI at different scales faster.

Also adds a utility method to display class to force a new device scale
factor.

COMPONENT=System Tray, Ash switches, Ash strings, about flags, display
BUG=718639
==========

[commit-bot: I haz the power, 2017-05-09 23:56:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 23:56:13]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has
not started yet; builder either lacks capacity or does not exist (misspelled?))
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet;
builder either lacks capacity or does not exist (misspelled?))
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, build
has not started yet; builder either lacks capacity or does not exist
(misspelled?))
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
build has not started yet; builder either lacks capacity or does not exist
(misspelled?))
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build
has not started yet; builder either lacks capacity or does not exist
(misspelled?))
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
build has not started yet; builder either lacks capacity or does not exist
(misspelled?))

[malaykeshav, 2017-05-10 05:28:27]

PTAL

https://codereview.chromium.org/2855143004/diff/160001/ash/system/display_sca...
File ash/system/display_scale/scale_view.cc (right):

https://codereview.chromium.org/2855143004/diff/160001/ash/system/display_sca...
ash/system/display_scale/scale_view.cc:88: if (reason ==
views::VALUE_CHANGED_BY_USER)
On 2017/05/09 at 03:58:21, oshima wrote:
> nit: {}

Done

https://codereview.chromium.org/2855143004/diff/160001/ui/display/display.cc
File ui/display/display.cc (right):

https://codereview.chromium.org/2855143004/diff/160001/ui/display/display.cc#...
ui/display/display.cc:97: g_forced_device_scale_factor = -1.0;
On 2017/05/09 at 03:58:21, oshima wrote:
> I somehow missed this change in the first review.
> 
> Just setting g_forced_device_scale_factor, g_has_forced_device_scale_factor
didn't work?

It should work. I just read the comment for `g_has_forced_device_scale_factor`: 
"This variable tracks whether the forced device scale factor switch needs to be
read from the command line" which was misleading.

[oshima, 2017-05-10 06:35:52]

On 2017/05/10 05:28:27, malaykeshav wrote:
> PTAL
> 
>
https://codereview.chromium.org/2855143004/diff/160001/ash/system/display_sca...
> File ash/system/display_scale/scale_view.cc (right):
> 
>
https://codereview.chromium.org/2855143004/diff/160001/ash/system/display_sca...
> ash/system/display_scale/scale_view.cc:88: if (reason ==
> views::VALUE_CHANGED_BY_USER)
> On 2017/05/09 at 03:58:21, oshima wrote:
> > nit: {}
> 
> Done
> 
> https://codereview.chromium.org/2855143004/diff/160001/ui/display/display.cc
> File ui/display/display.cc (right):
> 
>
https://codereview.chromium.org/2855143004/diff/160001/ui/display/display.cc#...
> ui/display/display.cc:97: g_forced_device_scale_factor = -1.0;
> On 2017/05/09 at 03:58:21, oshima wrote:
> > I somehow missed this change in the first review.
> > 
> > Just setting g_forced_device_scale_factor, g_has_forced_device_scale_factor
> didn't work?
> 
> It should work. I just read the comment for
`g_has_forced_device_scale_factor`: 
> "This variable tracks whether the forced device scale factor switch needs to
be
> read from the command line" which was misleading.

on second thought, I think the current code is okay. lgtm

[malaykeshav, 2017-05-10 09:06:18]

The CQ bit was checked by malaykeshav@chromium.org

[commit-bot: I haz the power, 2017-05-10 09:06:54]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 11:20:57]

CQ is committing da patch.

Bot data: {"patchset_id": 200001, "attempt_start_ts": 1494407178749550,
"parent_rev": "044dbd1b936309e5cc73c52280a73336364d46ec", "commit_rev":
"49cd16f6b9d7512e5cbcc02b41434d8e6cfe7134"}

[commit-bot: I haz the power, 2017-05-10 11:21:18]

Description was changed from

==========
Implements a display scale tray setting behind a chrome switch

Implements a system tray setting to update and force a device scale factor
on the device. This tray setting is hidden behind a switch. This will help in
debugging and testing UI at different scales faster.

Also adds a utility method to display class to force a new device scale
factor.

COMPONENT=System Tray, Ash switches, Ash strings, about flags, display
BUG=718639
==========

to

==========
Implements a display scale tray setting behind a chrome switch

Implements a system tray setting to update and force a device scale factor
on the device. This tray setting is hidden behind a switch. This will help in
debugging and testing UI at different scales faster.

Also adds a utility method to display class to force a new device scale
factor.

COMPONENT=System Tray, Ash switches, Ash strings, about flags, display
BUG=718639

Review-Url: https://codereview.chromium.org/2855143004
Cr-Commit-Position: refs/heads/master@{#470531}
Committed:
https://chromium.googlesource.com/chromium/src/+/49cd16f6b9d7512e5cbcc02b4143...
==========

[commit-bot: I haz the power, 2017-05-10 11:21:19]

Committed patchset #9 (id:200001) as
https://chromium.googlesource.com/chromium/src/+/49cd16f6b9d7512e5cbcc02b4143...