Add memory metrics to TBMv2 media benchmarks

Add memory metrics to TBMv2 media benchmarks

BUG=700160
Review-Url: https://codereview.chromium.org/2855133007
Cr-Commit-Position: refs/heads/master@{#474713}
Committed: https://chromium.googlesource.com/chromium/src/+/ae90924e27f9704858ffb753307d9313925bce80

[johnchen, 2017-05-23 16:35:58]

johnchen@chromium.org changed reviewers:
+ nednguyen@google.com

[johnchen, 2017-05-23 16:35:58]

Ned,

This change adds memory metrics to TBMv2 media benchmarks
(media.tough_video_cases_tbmv2 and media.android.tough_video_cases_tbmv2). Could
you please take a look?

Thanks,
John

[nednguyen, 2017-05-24 19:42:03]

On 2017/05/23 16:35:58, johnchen wrote:
> Ned,
> 
> This change adds memory metrics to TBMv2 media benchmarks
> (media.tough_video_cases_tbmv2 and media.android.tough_video_cases_tbmv2).
Could
> you please take a look?
> 
> Thanks,
> John

lgtm
+juan in case there is anything special about power metric that John also need
to be aware of.

[johnchen, 2017-05-24 20:05:19]

On 2017/05/24 19:42:03, nednguyen wrote:
> lgtm
> +juan in case there is anything special about power metric that John also need
> to be aware of.
Hi Ned, I don't see juan in either reviewer or CC list. Did you miss updating
the list? Thanks.

[nednguyen, 2017-05-24 20:59:05]

Description was changed from

==========
Add memory metrics to TBMv2 media benchmarks

BUG=700160
==========

to

==========
Add memory metrics to TBMv2 media benchmarks

BUG=700160
==========

[nednguyen, 2017-05-24 20:59:06]

nednguyen@google.com changed reviewers:
+ perezju@chromium.org

[nednguyen, 2017-05-24 20:59:18]

On 2017/05/24 20:05:19, johnchen wrote:
> On 2017/05/24 19:42:03, nednguyen wrote:
> > lgtm
> > +juan in case there is anything special about power metric that John also
need
> > to be aware of.
> Hi Ned, I don't see juan in either reviewer or CC list. Did you miss updating
> the list? Thanks.

Sorry, I just added Juan

[perezju, 2017-05-25 08:22:15]

lgtm

Just make sure to keep an eye on your existing power/cpu metrics; wouldn't be
surprised if adding memory could affect your baseline on those.

[johnchen, 2017-05-25 16:26:51]

The CQ bit was checked by johnchen@chromium.org

[commit-bot: I haz the power, 2017-05-25 16:27:20]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 18:27:15]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495729611959060,
"parent_rev": "3410b8cf2a5048561552018a9b3ca10c14698a5a", "commit_rev":
"ae90924e27f9704858ffb753307d9313925bce80"}

[commit-bot: I haz the power, 2017-05-25 18:27:28]

Description was changed from

==========
Add memory metrics to TBMv2 media benchmarks

BUG=700160
==========

to

==========
Add memory metrics to TBMv2 media benchmarks

BUG=700160

Review-Url: https://codereview.chromium.org/2855133007
Cr-Commit-Position: refs/heads/master@{#474713}
Committed:
https://chromium.googlesource.com/chromium/src/+/ae90924e27f9704858ffb753307d...
==========

[commit-bot: I haz the power, 2017-05-25 18:27:29]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ae90924e27f9704858ffb753307d...

[CalebRouleau, 2017-06-08 22:53:52]

crouleau@chromium.org changed reviewers:
+ crouleau@chromium.org

[CalebRouleau, 2017-06-08 22:53:52]

lgtm