Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2855133006: Fix FastAssign for self-assignment (Closed)

Created:
3 years, 7 months ago by Jakob Kummerow
Modified:
3 years, 7 months ago
Reviewers:
Camillo Bruni
CC:
gsathya, v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Fix FastAssign for self-assignment Storing a data property on |target| can change |source|'s map if |target| and |source| are the same object. BUG=chromium:716520 Review-Url: https://codereview.chromium.org/2855133006 Cr-Commit-Position: refs/heads/master@{#45097} Committed: https://chromium.googlesource.com/v8/v8/+/1f51f66f738a05b5f0181e7e37ab171b6f112bac

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -2 lines) Patch
M src/objects.cc View 1 chunk +1 line, -2 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-716520.js View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Jakob Kummerow
Camillo: PTAL. Sathya: FYI.
3 years, 7 months ago (2017-05-04 12:54:46 UTC) #2
Camillo Bruni
lgtm
3 years, 7 months ago (2017-05-04 13:01:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2855133006/1
3 years, 7 months ago (2017-05-04 13:39:33 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 13:41:16 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/1f51f66f738a05b5f0181e7e37ab171b6f1...

Powered by Google App Engine
This is Rietveld 408576698