Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 2855133005: IsAccessWhiteListed(): avoid unnecessary stringification. (Closed)

Created:
3 years, 7 months ago by sof
Modified:
3 years, 7 months ago
Reviewers:
haraken, Mike West
CC:
chromium-reviews, blink-reviews, kinuko+watch
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

IsAccessWhiteListed(): avoid unnecessary stringification. The origin whitelist may well be empty, so check that first before taking on the stringification of the security origin. R= BUG= Review-Url: https://codereview.chromium.org/2855133005 Cr-Commit-Position: refs/heads/master@{#469300} Committed: https://chromium.googlesource.com/chromium/src/+/b6bec5fd85d27f68ba6ecdee9217ee0638e391ab

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M third_party/WebKit/Source/platform/weborigin/SecurityPolicy.cpp View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
sof
please take a look. (just something noticed while at PA buffer partition allocations.)
3 years, 7 months ago (2017-05-04 06:48:56 UTC) #4
haraken
LGTM
3 years, 7 months ago (2017-05-04 09:32:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2855133005/1
3 years, 7 months ago (2017-05-04 09:34:10 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 09:37:51 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b6bec5fd85d27f68ba6ecdee9217...

Powered by Google App Engine
This is Rietveld 408576698