Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 2855133002: Simplify PrintContext::ComputePageRectsWithPageSizeInternal(). (Closed)

Created:
3 years, 7 months ago by Lei Zhang
Modified:
3 years, 7 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify PrintContext::ComputePageRectsWithPageSizeInternal(). Review-Url: https://codereview.chromium.org/2855133002 Cr-Commit-Position: refs/heads/master@{#469260} Committed: https://chromium.googlesource.com/chromium/src/+/d9d911d83ab03a50afb5b9606b778e19b33ae5d3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -29 lines) Patch
M third_party/WebKit/Source/core/page/PrintContext.cpp View 2 chunks +15 lines, -29 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Lei Zhang
The red bots are probably not mine.
3 years, 7 months ago (2017-05-03 20:59:46 UTC) #6
haraken
LGTM
3 years, 7 months ago (2017-05-04 01:57:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2855133002/1
3 years, 7 months ago (2017-05-04 01:58:41 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 03:35:51 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d9d911d83ab03a50afb5b9606b77...

Powered by Google App Engine
This is Rietveld 408576698