Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 2855123009: Expose SerializedScriptValue data through a non-copying view. (Closed)

Created:
3 years, 7 months ago by jbroman
Modified:
3 years, 7 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews, jbroman+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Expose SerializedScriptValue data without requiring a copy. This view does not pad to an even size. To begin with, use this to implement internals.serializeObject. BUG=718595 Review-Url: https://codereview.chromium.org/2855123009 Cr-Commit-Position: refs/heads/master@{#469995} Committed: https://chromium.googlesource.com/chromium/src/+/f18f120c6b5ebef92bd05d50dd60935185daced9

Patch Set 1 #

Patch Set 2 : update layout test results to not include padding #

Messages

Total messages: 27 (18 generated)
jbroman
3 years, 7 months ago (2017-05-05 18:45:26 UTC) #10
haraken
LGTM
3 years, 7 months ago (2017-05-06 02:29:22 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2855123009/20001
3 years, 7 months ago (2017-05-06 11:09:24 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/364340)
3 years, 7 months ago (2017-05-06 18:29:49 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2855123009/20001
3 years, 7 months ago (2017-05-07 16:25:48 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/420215)
3 years, 7 months ago (2017-05-07 16:50:16 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2855123009/20001
3 years, 7 months ago (2017-05-07 17:34:11 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2855123009/20001
3 years, 7 months ago (2017-05-08 15:52:27 UTC) #24
commit-bot: I haz the power
3 years, 7 months ago (2017-05-08 16:00:36 UTC) #27
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f18f120c6b5ebef92bd05d50dd60...

Powered by Google App Engine
This is Rietveld 408576698