Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1520)

Issue 2855123008: VR: Make work done during onResume in VrShellDelegate asynchronous. (Closed)

Created:
3 years, 7 months ago by mthiesse
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

VR: Make work done during onResume in VrShellDelegate asynchronous. Makes registerDaydreamIntent run after onResume. Makes static checking of VR support level in onResume an async task. Note that doing this work asynchronously is racy. In practice this shouldn't be an issue because the user would have to put their phone into their daydream headset within a few milliseconds of launching chrome. The failure mode is also not terrible, the user would return to Daydream home instead of Chrome. BUG=718136 Review-Url: https://codereview.chromium.org/2859893002 Cr-Commit-Position: refs/heads/master@{#469141} (cherry picked from commit 2d3151bb4c3bf0346ceec9c4b43f895607fe8d2c) Review-Url: https://codereview.chromium.org/2855123008 . Cr-Commit-Position: refs/branch-heads/3071@{#415} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/aab1355ed623db4c9af5a6ec04693e170db9bb3d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -12 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java View 6 chunks +44 lines, -12 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
mthiesse
3 years, 7 months ago (2017-05-05 14:34:17 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
aab1355ed623db4c9af5a6ec04693e170db9bb3d.

Powered by Google App Engine
This is Rietveld 408576698