Move the fake omnibox constraints out of GoogleLandingViewController

ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_utils.h

Index: ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_utils.h
diff --git a/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_utils.h b/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_utils.h
index 70c90cddf4713c880e36c532344625dfd6fe2f1f..6e01b90acd75af855d4b235832fe8398ed3bfb2d 100644
--- a/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_utils.h
+++ b/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_utils.h
@@ -28,6 +28,13 @@ CGRect searchFieldFrame(CGFloat width, BOOL logoIsShowing);
 CGFloat heightForLogoHeader(CGFloat width,
                             BOOL logoIsShowing,
                             BOOL promoCanShow);
+// Returns a UILabel containing the hint for the omnibox, added to the

[marq (ping after 24h), 2017/05/03 15:22:05]

Normally I would object to a function that does this kind of thing, but since
this is in the context of major refactoring, I'm fine with it for the time
being.

[gambard, 2017/05/03 15:27:35]

Which part are you disagreeing on? My first intent was to create the object and
add it to the searchTapTarget outside this helper, then only configure it
(including the constraint) in the helper. Would that be more acceptable?

[marq (ping after 24h), 2017/05/10 09:11:26]

Yes; in general I don't like functions that return values and also have side
effects, so having a utility that just arranges existing views passed into it
seems cleaner. 

[gambard, 2017/05/10 12:14:44]

Acknowledged.

+// |searchTapTarget| and constrained.
+UILabel* configuredSearchHintLabel(UIButton* searchTapTarget,
+                                   CGFloat searchFieldWidth);
+// Returns a button for the voice search, added to the |searcgTapTarget| and

[marq (ping after 24h), 2017/05/03 15:22:05]

searcg -> search

[gambard, 2017/05/10 12:14:44]

Done.

+// constrained.
+UIButton* configuredVoiceTapTarget(UIButton* searchTapTarget);
 
 }  // namespace content_suggestions