Move the fake omnibox constraints out of GoogleLandingViewController

ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_utils.h

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef IOS_CHROME_BROWSER_UI_CONTENT_SUGGESTIONS_CONTENT_SUGGESTIONS_COLLECTION_UTILS_H_
 #define IOS_CHROME_BROWSER_UI_CONTENT_SUGGESTIONS_CONTENT_SUGGESTIONS_COLLECTION_UTILS_H_
 
 #import <UIKit/UIKit.h>
 
 namespace content_suggestions {
@@ skipping 10 matching lines @@
 CGRect doodleFrame(CGFloat width, BOOL logoIsShowing);
 // Returns the proper frame for the search field inside a view with a |width|.
 // |logoIsShowing| refers to the Google logo or the doodle.
 CGRect searchFieldFrame(CGFloat width, BOOL logoIsShowing);
 // Returns the expected height of the NewTabPageHeaderView inside a view with a
 // |width|. |logoIsShowing| refers to the Google logo or the doodle.
 // |promoCanShow| represents whether a what's new promo can be displayed.
 CGFloat heightForLogoHeader(CGFloat width,
                             BOOL logoIsShowing,
                             BOOL promoCanShow);
+// Returns a UILabel containing the hint for the omnibox, added to the

[marq (ping after 24h), 2017/05/03 15:22:05]

Normally I would object to a function that does this kind of thing, but since
this is in the context of major refactoring, I'm fine with it for the time
being.

[gambard, 2017/05/03 15:27:35]

Which part are you disagreeing on? My first intent was to create the object and
add it to the searchTapTarget outside this helper, then only configure it
(including the constraint) in the helper. Would that be more acceptable?

[marq (ping after 24h), 2017/05/10 09:11:26]

Yes; in general I don't like functions that return values and also have side
effects, so having a utility that just arranges existing views passed into it
seems cleaner. 

[gambard, 2017/05/10 12:14:44]

Acknowledged.

+// |searchTapTarget| and constrained.
+UILabel* configuredSearchHintLabel(UIButton* searchTapTarget,
+                                   CGFloat searchFieldWidth);
+// Returns a button for the voice search, added to the |searcgTapTarget| and

[marq (ping after 24h), 2017/05/03 15:22:05]

searcg -> search

[gambard, 2017/05/10 12:14:44]

Done.

+// constrained.
+UIButton* configuredVoiceTapTarget(UIButton* searchTapTarget);
 
 }  // namespace content_suggestions
 
 #endif  // IOS_CHROME_BROWSER_UI_CONTENT_SUGGESTIONS_CONTENT_SUGGESTIONS_COLLECTION_UTILS_H_