Remove a new usage of LabelButton::SetStyle (in ChromeCleanerDialog).

Remove a new usage of LabelButton::SetStyle (in ChromeCleanerDialog).

This still can't be removed until secondary MD is on by default (and it
can't be protected for now either since Translate is still using it).
Rename to SetStyleDeprecated to discourage further use.

BUG=642920
Review-Url: https://codereview.chromium.org/2855093002
Cr-Commit-Position: refs/heads/master@{#469362}
Committed: https://chromium.googlesource.com/chromium/src/+/3766983525e4061113eadae678d3f18e6010fe81

[Evan Stade, 2017-05-03 00:58:20]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[Evan Stade, 2017-05-03 00:58:45]

estade@chromium.org changed reviewers:
+ tapted@chromium.org

[commit-bot: I haz the power, 2017-05-03 00:59:02]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 01:12:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 01:12:39]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tapted, 2017-05-03 01:36:02]

lgtm .. with an optional suggestion

https://codereview.chromium.org/2855093002/diff/1/chrome/browser/ui/views/chr...
File chrome/browser/ui/views/chrome_cleaner_dialog.cc (right):

https://codereview.chromium.org/2855093002/diff/1/chrome/browser/ui/views/chr...
chrome/browser/ui/views/chrome_cleaner_dialog.cc:45:
advanced_button_(MdTextButton::CreateSecondaryUiButton(
optional: the member isn't really needed..
ChromeCleanerDialog::CreateExtraView() could just `return
MdTextButton::CreateSecondaryUiButton(..)` (|advanced_button_| is only used for
a DCHECK otherwise)

[Evan Stade, 2017-05-03 15:09:39]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-03 15:10:09]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Evan Stade, 2017-05-03 15:10:38]

estade@chromium.org changed reviewers:
+ sky@chromium.org

[Evan Stade, 2017-05-03 15:10:39]

+sky for c/b/u/v

https://codereview.chromium.org/2855093002/diff/1/chrome/browser/ui/views/chr...
File chrome/browser/ui/views/chrome_cleaner_dialog.cc (right):

https://codereview.chromium.org/2855093002/diff/1/chrome/browser/ui/views/chr...
chrome/browser/ui/views/chrome_cleaner_dialog.cc:45:
advanced_button_(MdTextButton::CreateSecondaryUiButton(
On 2017/05/03 01:36:02, tapted wrote:
> optional: the member isn't really needed..
> ChromeCleanerDialog::CreateExtraView() could just `return
> MdTextButton::CreateSecondaryUiButton(..)` (|advanced_button_| is only used
for
> a DCHECK otherwise)

I'm on the fence because I think that DCHECK is mildly useful, but done.

[commit-bot: I haz the power, 2017-05-03 15:45:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 15:45:29]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[sky, 2017-05-04 04:12:59]

LGTM

[Evan Stade, 2017-05-04 13:01:22]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2017-05-04 13:01:23]

The patchset sent to the CQ was uploaded after l-g-t-m from tapted@chromium.org
Link to the patchset: https://codereview.chromium.org/2855093002/#ps20001
(title: "fix views examples")

[commit-bot: I haz the power, 2017-05-04 13:01:39]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 13:37:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-04 13:37:46]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[Evan Stade, 2017-05-04 15:56:55]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2017-05-04 15:57:17]

The CQ bit was unchecked by estade@chromium.org

[commit-bot: I haz the power, 2017-05-04 15:57:21]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Evan Stade, 2017-05-04 16:00:46]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2017-05-04 16:00:46]

The patchset sent to the CQ was uploaded after l-g-t-m from tapted@chromium.org,
sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2855093002/#ps40001
(title: "views::")

[commit-bot: I haz the power, 2017-05-04 16:01:05]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 16:54:57]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493913646423260,
"parent_rev": "6d0700c264fabe9d1b6857b2f860759544c4e640", "commit_rev":
"3766983525e4061113eadae678d3f18e6010fe81"}

[commit-bot: I haz the power, 2017-05-04 16:56:10]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493913646423260,
"parent_rev": "6d0700c264fabe9d1b6857b2f860759544c4e640", "commit_rev":
"3766983525e4061113eadae678d3f18e6010fe81"}

[commit-bot: I haz the power, 2017-05-04 16:56:43]

Description was changed from

==========
Remove a new usage of LabelButton::SetStyle (in ChromeCleanerDialog).

This still can't be removed until secondary MD is on by default (and it
can't be protected for now either since Translate is still using it).
Rename to SetStyleDeprecated to discourage further use.

BUG=642920
==========

to

==========
Remove a new usage of LabelButton::SetStyle (in ChromeCleanerDialog).

This still can't be removed until secondary MD is on by default (and it
can't be protected for now either since Translate is still using it).
Rename to SetStyleDeprecated to discourage further use.

BUG=642920

Review-Url: https://codereview.chromium.org/2855093002
Cr-Commit-Position: refs/heads/master@{#469362}
Committed:
https://chromium.googlesource.com/chromium/src/+/3766983525e4061113eadae678d3...
==========

[commit-bot: I haz the power, 2017-05-04 16:56:47]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/3766983525e4061113eadae678d3...