Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 2855033002: [Home] Fix top-offset for native pages (Closed)

Created:
3 years, 7 months ago by Theresa
Modified:
3 years, 7 months ago
Reviewers:
gone
CC:
chromium-reviews, noyau+watch_chromium.org, ntp-dev+reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Home] Fix top-offset for native pages BUG=706683 Review-Url: https://codereview.chromium.org/2855033002 Cr-Commit-Position: refs/heads/master@{#469396} Committed: https://chromium.googlesource.com/chromium/src/+/63c287aa94594af1018f6c3b966aa72e6f315801

Patch Set 1 #

Patch Set 2 : Fix test #

Total comments: 2

Patch Set 3 : [Home] Fix top-offset for native pages #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -8 lines) Patch
M chrome/android/java/res/layout/recent_tabs_page.xml View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/BasicNativePage.java View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NativePageFactory.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsPage.java View 1 2 3 chunks +10 lines, -1 line 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/ntp/NativePageFactoryTest.java View 1 3 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
Theresa
ptal
3 years, 7 months ago (2017-05-02 22:33:16 UTC) #4
Theresa
I need to update NativePageFactoryTest.java to fix the compilation error.
3 years, 7 months ago (2017-05-02 23:15:10 UTC) #7
gone
https://codereview.chromium.org/2855033002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsPage.java File chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsPage.java (right): https://codereview.chromium.org/2855033002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsPage.java#newcode109 chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsPage.java:109: ApiCompatibilityUtils.getPaddingStart(recentTabsRoot), getPaddingEnd?
3 years, 7 months ago (2017-05-04 17:04:22 UTC) #10
Theresa
https://codereview.chromium.org/2855033002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsPage.java File chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsPage.java (right): https://codereview.chromium.org/2855033002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsPage.java#newcode109 chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsPage.java:109: ApiCompatibilityUtils.getPaddingStart(recentTabsRoot), On 2017/05/04 17:04:22, slow (dfalcantara) wrote: > getPaddingEnd? ...
3 years, 7 months ago (2017-05-04 17:56:15 UTC) #12
gone
lgtm
3 years, 7 months ago (2017-05-04 17:59:23 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2855033002/40001
3 years, 7 months ago (2017-05-04 18:01:18 UTC) #15
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 18:41:38 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/63c287aa94594af1018f6c3b966a...

Powered by Google App Engine
This is Rietveld 408576698