Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 2855023002: Import various network-related tests from web-platform-tests (Closed)

Created:
3 years, 7 months ago by foolip
Modified:
3 years, 7 months ago
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Import various network-related tests from web-platform-tests R=tyoshino@chromium.org Review-Url: https://codereview.chromium.org/2855023002 Cr-Commit-Position: refs/heads/master@{#469983} Committed: https://chromium.googlesource.com/chromium/src/+/d6764ff06dab25c98137d54424dd37bd23844e49

Patch Set 1 #

Total comments: 2

Patch Set 2 : drop cookies and http #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M third_party/WebKit/LayoutTests/W3CImportExpectations View 1 5 chunks +10 lines, -5 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (5 generated)
foolip
3 years, 7 months ago (2017-05-02 21:49:28 UTC) #1
tyoshino (SeeGerritForStatus)
+kouhei regarding external/wpt/http (https://github.com/w3c/web-platform-tests/tree/master/http) +mmenke +mkwst regarding external/wpt/cookies (https://github.com/w3c/web-platform-tests/tree/master/cookies) https://codereview.chromium.org/2855023002/diff/1/third_party/WebKit/LayoutTests/W3CImportExpectations File third_party/WebKit/LayoutTests/W3CImportExpectations (right): https://codereview.chromium.org/2855023002/diff/1/third_party/WebKit/LayoutTests/W3CImportExpectations#newcode52 third_party/WebKit/LayoutTests/W3CImportExpectations:52: ...
3 years, 7 months ago (2017-05-08 08:37:37 UTC) #4
tyoshino (SeeGerritForStatus)
Except for the 2, looks good.
3 years, 7 months ago (2017-05-08 08:38:13 UTC) #5
foolip
I have dropped cookies and http, I'll handle those separately.
3 years, 7 months ago (2017-05-08 09:02:45 UTC) #6
tyoshino (SeeGerritForStatus)
lgtm
3 years, 7 months ago (2017-05-08 09:19:59 UTC) #7
Mike West
On 2017/05/08 at 09:02:45, foolip wrote: > I have dropped cookies and http, I'll handle ...
3 years, 7 months ago (2017-05-08 10:55:42 UTC) #8
kouhei (in TOK)
lgtm looking forward to http tests
3 years, 7 months ago (2017-05-08 13:08:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2855023002/20001
3 years, 7 months ago (2017-05-08 13:14:46 UTC) #11
foolip
On 2017/05/08 13:08:28, kouhei (on transit) wrote: > lgtm > looking forward to http tests ...
3 years, 7 months ago (2017-05-08 13:18:31 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-08 14:42:23 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d6764ff06dab25c98137d54424dd...

Powered by Google App Engine
This is Rietveld 408576698