Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Issue 2855003004: [heap] Use shared markbits in the concurrent marker. (Closed)

Created:
3 years, 7 months ago by ulan
Modified:
3 years, 7 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), Michael Hablich
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Use shared markbits in the concurrent marker. The concurrent marker now colors objects grey and black using the atomic markbit operations. The heap visitor is changed in two ways: 1) It iterates the map pointer of each object. 2) It guards object visitation with a predicate, which is overridden in the concurrent marker with the result of GreyToBlack transition. BUG=chromium:694255 Review-Url: https://codereview.chromium.org/2855003004 Cr-Commit-Position: refs/heads/master@{#45099} Committed: https://chromium.googlesource.com/v8/v8/+/b0db0541ee0f9b749cbaefc9d92b61293234e951

Patch Set 1 #

Patch Set 2 : comment #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -32 lines) Patch
M src/flag-definitions.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/heap/concurrent-marking.cc View 4 chunks +32 lines, -20 lines 0 comments Download
M src/heap/objects-visiting.h View 1 1 chunk +8 lines, -1 line 0 comments Download
M src/heap/objects-visiting-inl.h View 8 chunks +44 lines, -10 lines 0 comments Download
M src/objects.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M src/objects-inl.h View 1 chunk +3 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (6 generated)
ulan
ptal
3 years, 7 months ago (2017-05-03 20:06:04 UTC) #3
Hannes Payer (out of office)
lgtm
3 years, 7 months ago (2017-05-04 11:31:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2855003004/60001
3 years, 7 months ago (2017-05-04 13:21:55 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 13:55:53 UTC) #10
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/b0db0541ee0f9b749cbaefc9d92b6129323...

Powered by Google App Engine
This is Rietveld 408576698