[LayoutNG] Add NGLayoutInputNode::ShowNodeTree

[LayoutNG] Add NGLayoutInputNode::ShowNodeTree

NGLayoutInputNode::ShowNodeTree will be used for debugging or
demonstration purposes(ex. show how the changes in LayoutObject tree will
look like in LayoutNG)

BUG=636993
Review-Url: https://codereview.chromium.org/2854993002
Cr-Commit-Position: refs/heads/master@{#469203}
Committed: https://chromium.googlesource.com/chromium/src/+/9d0f65d61b81fdce1e9a6ffd581cb9e69a429d81

[Gleb Lanbin, 2017-05-02 20:22:22]

glebl@chromium.org changed reviewers:
+ ikilpatrick@chromium.org

[Gleb Lanbin, 2017-05-02 20:22:27]

The CQ bit was checked by glebl@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-02 20:23:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Gleb Lanbin, 2017-05-02 20:27:40]

The CQ bit was checked by glebl@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-02 20:27:53]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 22:31:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-02 22:31:12]

Dry run: This issue passed the CQ dry run.

[ikilpatrick, 2017-05-03 17:34:32]

lgtm

https://codereview.chromium.org/2854993002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/ng/inline/ng_inline_item.h (right):

https://codereview.chromium.org/2854993002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/inline/ng_inline_item.h:8: #include
"core/layout/LayoutObject.h"
possible to avoid this include for our non-goma friends?

[Gleb Lanbin, 2017-05-03 17:48:20]

thanks for the review

https://codereview.chromium.org/2854993002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/ng/inline/ng_inline_item.h (right):

https://codereview.chromium.org/2854993002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/inline/ng_inline_item.h:8: #include
"core/layout/LayoutObject.h"
On 2017/05/03 17:34:32, ikilpatrick wrote:
> possible to avoid this include for our non-goma friends?

Usually I prefer to use #include instead of forward declaration if I need it for
.cc file. This is the case. I use GetLayoutObject()->DebugName() in cc file.

[ikilpatrick, 2017-05-03 17:54:28]

https://codereview.chromium.org/2854993002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/ng/inline/ng_inline_item.h (right):

https://codereview.chromium.org/2854993002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/inline/ng_inline_item.h:8: #include
"core/layout/LayoutObject.h"
On 2017/05/03 17:48:20, Gleb Lanbin wrote:
> On 2017/05/03 17:34:32, ikilpatrick wrote:
> > possible to avoid this include for our non-goma friends?
> 
> Usually I prefer to use #include instead of forward declaration if I need it
for
> .cc file. This is the case. I use GetLayoutObject()->DebugName() in cc file. 

Yeah, there is on-going debate at the moment about this - the only problem with
agressively including things is that is slows down compiles a lot of external
contributors which don't have our infra.

[Gleb Lanbin, 2017-05-03 19:47:49]

https://codereview.chromium.org/2854993002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/ng/inline/ng_inline_item.h (right):

https://codereview.chromium.org/2854993002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/inline/ng_inline_item.h:8: #include
"core/layout/LayoutObject.h"
On 2017/05/03 17:54:28, ikilpatrick wrote:
> On 2017/05/03 17:48:20, Gleb Lanbin wrote:
> > On 2017/05/03 17:34:32, ikilpatrick wrote:
> > > possible to avoid this include for our non-goma friends?
> > 
> > Usually I prefer to use #include instead of forward declaration if I need it
> for
> > .cc file. This is the case. I use GetLayoutObject()->DebugName() in cc file.

> 
> Yeah, there is on-going debate at the moment about this - the only problem
with
> agressively including things is that is slows down compiles a lot of external
> contributors which don't have our infra.

Done.

[Gleb Lanbin, 2017-05-03 19:47:54]

The CQ bit was checked by glebl@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-03 19:48:37]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 21:56:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 21:56:26]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Gleb Lanbin, 2017-05-03 21:59:15]

The CQ bit was checked by glebl@chromium.org

[Gleb Lanbin, 2017-05-03 21:59:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
ikilpatrick@chromium.org
Link to the patchset: https://codereview.chromium.org/2854993002/#ps40001
(title: "Use forward declaration for LayoutObject")

[commit-bot: I haz the power, 2017-05-03 22:00:14]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 22:13:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 22:13:46]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Gleb Lanbin, 2017-05-03 22:16:48]

glebl@chromium.org changed reviewers:
+ cbiesinger@chromium.org

[Gleb Lanbin, 2017-05-03 22:17:08]

On 2017/05/03 22:16:49, Gleb Lanbin wrote:

adding cbiesinger@ for layout/BUILD.gn

[cbiesinger, 2017-05-03 23:04:42]

On 2017/05/03 22:17:08, Gleb Lanbin wrote:
> On 2017/05/03 22:16:49, Gleb Lanbin wrote:
> 
> adding cbiesinger@ for layout/BUILD.gn

lgtm

[Gleb Lanbin, 2017-05-03 23:43:33]

The CQ bit was checked by glebl@chromium.org

[commit-bot: I haz the power, 2017-05-03 23:44:12]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 23:50:35]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493855013544730,
"parent_rev": "0249478f91c38f2c29642c4717eafcdc62e65bfd", "commit_rev":
"9d0f65d61b81fdce1e9a6ffd581cb9e69a429d81"}

[commit-bot: I haz the power, 2017-05-03 23:50:45]

Description was changed from

==========
[LayoutNG] Add NGLayoutInputNode::ShowNodeTree

NGLayoutInputNode::ShowNodeTree will be used for debugging or
demonstration purposes(ex. show how the changes in LayoutObject tree will
look like in LayoutNG)

BUG=636993
==========

to

==========
[LayoutNG] Add NGLayoutInputNode::ShowNodeTree

NGLayoutInputNode::ShowNodeTree will be used for debugging or
demonstration purposes(ex. show how the changes in LayoutObject tree will
look like in LayoutNG)

BUG=636993

Review-Url: https://codereview.chromium.org/2854993002
Cr-Commit-Position: refs/heads/master@{#469203}
Committed:
https://chromium.googlesource.com/chromium/src/+/9d0f65d61b81fdce1e9a6ffd581c...
==========

[commit-bot: I haz the power, 2017-05-03 23:50:47]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9d0f65d61b81fdce1e9a6ffd581c...