Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2854973005: Local NTP: Cleanup non-default-language tests (Closed)

Created:
3 years, 7 months ago by Marc Treib
Modified:
3 years, 7 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Local NTP: Cleanup non-default-language tests BUG=none Review-Url: https://codereview.chromium.org/2854973005 Cr-Commit-Position: refs/heads/master@{#469299} Committed: https://chromium.googlesource.com/chromium/src/+/a301924653c2bf34a99d0c732fbee9dee732b0a4

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -13 lines) Patch
M chrome/browser/ui/search/local_ntp_browsertest.cc View 1 3 chunks +4 lines, -13 lines 1 comment Download

Depends on Patchset:

Messages

Total messages: 18 (14 generated)
Marc Treib
PTAL! https://codereview.chromium.org/2854973005/diff/20001/chrome/browser/ui/search/local_ntp_browsertest.cc File chrome/browser/ui/search/local_ntp_browsertest.cc (left): https://codereview.chromium.org/2854973005/diff/20001/chrome/browser/ui/search/local_ntp_browsertest.cc#oldcode253 chrome/browser/ui/search/local_ntp_browsertest.cc:253: if (!SwitchToFrench()) { This was doing the same ...
3 years, 7 months ago (2017-05-04 09:15:19 UTC) #12
Bernhard Bauer
lgtm
3 years, 7 months ago (2017-05-04 09:29:47 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2854973005/20001
3 years, 7 months ago (2017-05-04 09:31:48 UTC) #15
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 09:36:11 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a301924653c2bf34a99d0c732fbe...

Powered by Google App Engine
This is Rietveld 408576698