Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2854973003: Fix the Unthrottled download count for parallel download (Closed)

Created:
3 years, 7 months ago by qinmin
Modified:
3 years, 7 months ago
CC:
chromium-reviews, jam, David Trainor- moved to gerrit, darin-cc_chromium.org, kinuko+watch, blink-worker-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the Unthrottled download count for parallel download Only the main request should report a count, not the parallel requests. BUG=717679 Review-Url: https://codereview.chromium.org/2854973003 Cr-Commit-Position: refs/heads/master@{#469147} Committed: https://chromium.googlesource.com/chromium/src/+/462abbbe5b9206198afacbb76f5286da80de1106

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -13 lines) Patch
M content/browser/download/download_manager_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/download_request_core.h View 1 chunk +5 lines, -2 lines 0 comments Download
M content/browser/download/download_request_core.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/download/download_resource_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/download_worker.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/url_downloader.h View 1 chunk +4 lines, -2 lines 0 comments Download
M content/browser/download/url_downloader.cc View 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
qinmin
PTAL
3 years, 7 months ago (2017-05-02 19:35:10 UTC) #2
David Trainor- moved to gerrit
lgtm
3 years, 7 months ago (2017-05-03 20:45:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2854973003/1
3 years, 7 months ago (2017-05-03 20:52:20 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 21:56:00 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/462abbbe5b9206198afacbb76f52...

Powered by Google App Engine
This is Rietveld 408576698