Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2854973002: [Web Payments] Go to editors directly when "Add" buttons are pressed (Closed)

Created:
3 years, 7 months ago by anthonyvd
Modified:
3 years, 7 months ago
Reviewers:
Mathieu
CC:
chromium-reviews, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Web Payments] Go to editors directly when "Add" buttons are pressed BUG=710977 Review-Url: https://codereview.chromium.org/2854973002 Cr-Commit-Position: refs/heads/master@{#468943} Committed: https://chromium.googlesource.com/chromium/src/+/b355c151cb044f24b90f6933ec6b55bc409ab794

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix comments. #

Messages

Total messages: 13 (9 generated)
anthonyvd
Hi Math, PTAL!
3 years, 7 months ago (2017-05-02 18:55:28 UTC) #4
Mathieu
lgtm, nice cleanup too https://codereview.chromium.org/2854973002/diff/1/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc File chrome/browser/ui/views/payments/payment_sheet_view_controller.cc (right): https://codereview.chromium.org/2854973002/diff/1/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc#newcode59 chrome/browser/ui/views/payments/payment_sheet_view_controller.cc:59: // The tag for the ...
3 years, 7 months ago (2017-05-02 19:05:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2854973002/20001
3 years, 7 months ago (2017-05-03 10:53:25 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 11:57:25 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b355c151cb044f24b90f6933ec6b...

Powered by Google App Engine
This is Rietveld 408576698