Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 2854953005: Use constexpr TaskTraits constructor in chromeos. (Closed)

Created:
3 years, 7 months ago by fdoray
Modified:
3 years, 7 months ago
Reviewers:
gab, stevenjb
CC:
chromium-reviews, stevenjb+watch_chromium.org, hashimoto+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use constexpr TaskTraits constructor in chromeos. Use a constexpr constructor that accepts traits in any order instead of the builder pattern to construct TaskTraits in chromeos. BUG=713683 R=gab@chromium.org TBR=stevenjb@chromium.org Review-Url: https://codereview.chromium.org/2854953005 Cr-Commit-Position: refs/heads/master@{#469126} Committed: https://chromium.googlesource.com/chromium/src/+/f2a6f71677b02832b9dec1b94ce8abc43cd696df

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -70 lines) Patch
M chromeos/cert_loader.cc View 1 chunk +1 line, -4 lines 0 comments Download
M chromeos/dbus/debug_daemon_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chromeos/dbus/fake_auth_policy_client.cc View 2 chunks +4 lines, -10 lines 0 comments Download
M chromeos/dbus/fake_cros_disks_client.cc View 2 chunks +5 lines, -9 lines 0 comments Download
M chromeos/dbus/fake_permission_broker_client.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chromeos/dbus/lorgnette_manager_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chromeos/dbus/session_manager_client.cc View 7 chunks +11 lines, -28 lines 0 comments Download
M chromeos/network/client_cert_resolver.cc View 1 chunk +1 line, -4 lines 0 comments Download
M chromeos/settings/timezone_settings.cc View 1 chunk +4 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
fdoray
3 years, 7 months ago (2017-05-03 20:19:48 UTC) #1
fdoray
gab@: PTAL The change will then be TBRed to the owner.
3 years, 7 months ago (2017-05-03 20:19:50 UTC) #3
gab
lgtm
3 years, 7 months ago (2017-05-03 20:37:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2854953005/1
3 years, 7 months ago (2017-05-03 20:44:03 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 21:14:59 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f2a6f71677b02832b9dec1b94ce8...

Powered by Google App Engine
This is Rietveld 408576698