Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2854943005:
Converts WebApkIntegrationTest to JUnit4. (Closed)
DescriptionConverts WebApkIntegrationTest to JUnit4.
This will allow me to increase code reuse with a nice custom @Rule.
BUG=640116
Review-Url: https://codereview.chromium.org/2854943005
Cr-Commit-Position: refs/heads/master@{#469559}
Committed: https://chromium.googlesource.com/chromium/src/+/617af2a7cb227002906458a3050777a0c42f2210
Patch Set 1 #
Total comments: 4
Patch Set 2 : Uses InstrumentationRegistry now #Messages
Total messages: 20 (14 generated)
The CQ bit was checked by piotrs@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
piotrs@chromium.org changed reviewers: + pkotwicz@chromium.org, yolandyan@chromium.org
Hi folks, just a quick conversion to JUnit4 to allow for some better code reuse.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Thanks for doing this! https://codereview.chromium.org/2854943005/diff/1/chrome/android/javatests/sr... File chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebApkIntegrationTest.java (right): https://codereview.chromium.org/2854943005/diff/1/chrome/android/javatests/sr... chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebApkIntegrationTest.java:46: mActivityTestRule.getInstrumentation().getTargetContext(), WebApkActivity.class); You should use just InstrumentationRegistry.getTargetContext() here. ChromeActivityTestRule#getInstrumentation is only for migration period. https://codereview.chromium.org/2854943005/diff/1/chrome/android/javatests/sr... chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebApkIntegrationTest.java:52: mActivityTestRule.getInstrumentation().waitForIdleSync(); similarly, InstrumentationRegistry.getInstrumentation()
Patchset #3 (id:40001) has been deleted
Patchset #2 (id:20001) has been deleted
piotrs@chromium.org changed reviewers: + dominickn@chromium.org - pkotwicz@chromium.org
Thanks for comments! Done. Removing Peter from reviewers and adding Dominick, as he's the owner. https://codereview.chromium.org/2854943005/diff/1/chrome/android/javatests/sr... File chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebApkIntegrationTest.java (right): https://codereview.chromium.org/2854943005/diff/1/chrome/android/javatests/sr... chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebApkIntegrationTest.java:46: mActivityTestRule.getInstrumentation().getTargetContext(), WebApkActivity.class); On 2017/05/04 16:14:51, the real yoland wrote: > You should use just InstrumentationRegistry.getTargetContext() here. > ChromeActivityTestRule#getInstrumentation is only for migration period. Done. https://codereview.chromium.org/2854943005/diff/1/chrome/android/javatests/sr... chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebApkIntegrationTest.java:52: mActivityTestRule.getInstrumentation().waitForIdleSync(); On 2017/05/04 16:14:51, the real yoland wrote: > similarly, InstrumentationRegistry.getInstrumentation() Done.
lgtm % the CQ passing, thanks!
The CQ bit was checked by piotrs@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by piotrs@chromium.org
The CQ bit was checked by piotrs@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1493945390492280,
"parent_rev": "60b4d8b24e7096491e00b1745ec64129a5234e06", "commit_rev":
"617af2a7cb227002906458a3050777a0c42f2210"}
Message was sent while issue was closed.
Description was changed from ========== Converts WebApkIntegrationTest to JUnit4. This will allow me to increase code reuse with a nice custom @Rule. BUG=640116 ========== to ========== Converts WebApkIntegrationTest to JUnit4. This will allow me to increase code reuse with a nice custom @Rule. BUG=640116 Review-Url: https://codereview.chromium.org/2854943005 Cr-Commit-Position: refs/heads/master@{#469559} Committed: https://chromium.googlesource.com/chromium/src/+/617af2a7cb227002906458a30507... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as https://chromium.googlesource.com/chromium/src/+/617af2a7cb227002906458a30507... |
