Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2854923002:
Specify use_ozone=false for X11 CrOS trybots. (Closed)
|
Created:
3 years, 7 months ago by kylechar Modified:
3 years, 7 months ago Reviewers:
Dirk Pranke CC:
chromium-reviews, sky Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionSpecify use_ozone=false for X11 CrOS trybots.
By default use_ozone=false if target_os="chromeos". This causes
use_11=true and the X11 Chrome OS configuration to get built. Make
trybots that have implicit GN arg use_ozone=false specify it explicitly.
This will allow the default value for use_ozone to get changed without
changing the current trybot configurations.
BUG=671355
Review-Url: https://codereview.chromium.org/2854923002
Cr-Commit-Position: refs/heads/master@{#469316}
Committed: https://chromium.googlesource.com/chromium/src/+/59c10fe1fa4658261ac1ef92176e7f558a7c3687
Patch Set 1 #Patch Set 2 : Change name. #Messages
Total messages: 20 (15 generated)
The CQ bit was checked by kylechar@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Specify use_ozone=false for Chrome OS trybots. By default use_ozone=false on Chrome OS. Make trybots that are currently use_ozone=false specify this so that the default can be changed in the future without flipping all trybots too. BUG=671355 ========== to ========== Specify use_ozone=false for X11 Chrome OS trybots. By default use_ozone=false on Chrome OS. Make trybots that are currently use_ozone=false specify this so that the default can be changed in the future without flipping all trybots too. BUG=671355 ==========
Description was changed from ========== Specify use_ozone=false for X11 Chrome OS trybots. By default use_ozone=false on Chrome OS. Make trybots that are currently use_ozone=false specify this so that the default can be changed in the future without flipping all trybots too. BUG=671355 ========== to ========== Specify use_ozone=false for X11 CrOS trybots. By default use_ozone=false if target_os="chromeos". This causes use_11=true and the X11 Chrome OS configuration to get built. Make trybots that have implicit GN arg use_ozone=false specify it explicitly. This will allow the default value for use_ozone to get changed without changing the current trybot configurations. BUG=671355 ==========
Description was changed from ========== Specify use_ozone=false for X11 CrOS trybots. By default use_ozone=false if target_os="chromeos". This causes use_11=true and the X11 Chrome OS configuration to get built. Make trybots that have implicit GN arg use_ozone=false specify it explicitly. This will allow the default value for use_ozone to get changed without changing the current trybot configurations. BUG=671355 ========== to ========== Specify use_ozone=false for X11 CrOS trybots. By default use_ozone=false if target_os="chromeos". This causes use_11=true and the X11 Chrome OS configuration to get built. Make trybots that have implicit GN arg use_ozone=false specify it explicitly. This will allow the default value for use_ozone to get changed without changing the current trybot configurations. BUG=671355 ==========
kylechar@chromium.org changed reviewers: + dpranke@chromium.org
dpranke: OWNERS sky: FYI
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by kylechar@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Thanks Dirk!
The CQ bit was checked by kylechar@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493902037081130,
"parent_rev": "13da7bbd393358ca25773407d2139980b2002133", "commit_rev":
"59c10fe1fa4658261ac1ef92176e7f558a7c3687"}
Message was sent while issue was closed.
Description was changed from ========== Specify use_ozone=false for X11 CrOS trybots. By default use_ozone=false if target_os="chromeos". This causes use_11=true and the X11 Chrome OS configuration to get built. Make trybots that have implicit GN arg use_ozone=false specify it explicitly. This will allow the default value for use_ozone to get changed without changing the current trybot configurations. BUG=671355 ========== to ========== Specify use_ozone=false for X11 CrOS trybots. By default use_ozone=false if target_os="chromeos". This causes use_11=true and the X11 Chrome OS configuration to get built. Make trybots that have implicit GN arg use_ozone=false specify it explicitly. This will allow the default value for use_ozone to get changed without changing the current trybot configurations. BUG=671355 Review-Url: https://codereview.chromium.org/2854923002 Cr-Commit-Position: refs/heads/master@{#469316} Committed: https://chromium.googlesource.com/chromium/src/+/59c10fe1fa4658261ac1ef92176e... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/59c10fe1fa4658261ac1ef92176e... |
