Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2854913002: [builtins] Fix typo in macro name (Closed)

Created:
3 years, 7 months ago by mathias
Modified:
3 years, 7 months ago
Reviewers:
danno
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Fix typo in macro name During code review, `CASE` was renamed to `TFJ_CASE`, but one occurrence still refers to the old name. This patch fixes that. Ref. 2c995c8c50a39bb7177ce7e041f76ca97240ed98 R=danno@chromium.org BUG=v8:1956 LOG=N Review-Url: https://codereview.chromium.org/2854913002 Cr-Commit-Position: refs/heads/master@{#45040} Committed: https://chromium.googlesource.com/v8/v8/+/25b7e882f23fbf26d42fa755a90683030d29907f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/builtins/builtins.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
mathias
PTAL
3 years, 7 months ago (2017-05-02 15:10:15 UTC) #2
danno
lgtm
3 years, 7 months ago (2017-05-02 15:13:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2854913002/1
3 years, 7 months ago (2017-05-02 15:23:00 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 15:51:16 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/25b7e882f23fbf26d42fa755a90683030d2...

Powered by Google App Engine
This is Rietveld 408576698