cros: Hook AppCurrentWindowInternal setActivateOnPointer with aura side api

cros: Hook AppCurrentWindowInternal setActivateOnPointer with aura side api

Changes:
This is a follow up CL of https://codereview.chromium.org/2809073002/, which hooks AppCurrentWindowInternal setActivateOnPointer API with aura side changes.

BUG=657525
TEST=none

Review-Url: https://codereview.chromium.org/2854893004
Cr-Commit-Position: refs/heads/master@{#470390}
Committed: https://chromium.googlesource.com/chromium/src/+/dc2e682ca5558e90332f8443e23539a04f436273

[Qiang(Joe) Xu, 2017-05-02 22:52:51]

Description was changed from

==========
cros: Hook AppCurrentWindowInternal setActivateOnPointer with aura side
API

BUG=657525
TEST=none
==========

to

==========
cros: Hook AppCurrentWindowInternal setActivateOnPointer with aura side api

Changes:
This is a follow up CL of https://codereview.chromium.org/2809073002/, which
hooks AppCurrentWindowInternal setActivateOnPointer API with aura side changes.

BUG=657525
TEST=none
==========

[Qiang(Joe) Xu, 2017-05-02 22:52:51]

warx@chromium.org changed reviewers:
+ yamaguchi@chromium.org

[Qiang(Joe) Xu, 2017-05-02 22:56:51]

Hi Yamaguchi, would you mind taking a first look before I send out to owners?

I am not familiar with how AppCurrentWindowInternalFocusFunction is tested. I
could not find an example in code so currently there is no test coverage for
this CL.

Thanks!

[Qiang(Joe) Xu, 2017-05-03 18:20:39]

On 2017/05/02 22:56:51, Qiang(Joe) Xu wrote:
> Hi Yamaguchi, would you mind taking a first look before I send out to owners?
> 
> I am not familiar with how AppCurrentWindowInternalFocusFunction is tested. I
> could not find an example in code so currently there is no test coverage for
> this CL.
> 
> Thanks!

Btw, I mean AppCurrentWindowInternalFunction. Focus is just one of them.

[yamaguchi, 2017-05-08 09:09:40]

lgtm as a prospective user of the API.
oshima@ and the owners would have more background with the codebase.

[Qiang(Joe) Xu, 2017-05-08 16:58:58]

warx@chromium.org changed reviewers:
+ benwells@chromium.org, mpearson@chromium.org, oshima@chromium.org

[Qiang(Joe) Xu, 2017-05-08 17:37:10]

+mpearson, for e/b/extension_function_histogram_value.h
+benwells for other dir owner review
+oshima for guidance

Same question asked here: "I am not familiar with how
AppCurrentWindowInternalFunction is tested. I
could not find an example in code so currently there is no test coverage for
this CL."

[Mark P, 2017-05-08 22:26:04]

> +mpearson, for e/b/extension_function_histogram_value.h
Please update the xml file as well.

--mark

[Qiang(Joe) Xu, 2017-05-08 23:15:19]

tools/metrics/histograms/enums.xml updated, PTAL thanks

[Mark P, 2017-05-08 23:16:18]

extension_function_histogram_value.h lgtm

--mark

[oshima, 2017-05-09 05:44:06]

non owner lgtm

[benwells, 2017-05-09 07:58:47]

lgtm

[Qiang(Joe) Xu, 2017-05-09 15:25:43]

On 2017/05/09 07:58:47, benwells wrote:
> lgtm

Thanks for review!

[Qiang(Joe) Xu, 2017-05-09 15:25:48]

The CQ bit was checked by warx@chromium.org

[Qiang(Joe) Xu, 2017-05-09 15:25:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
yamaguchi@chromium.org
Link to the patchset: https://codereview.chromium.org/2854893004/#ps20001
(title: "update xml")

[commit-bot: I haz the power, 2017-05-09 15:26:29]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 18:39:34]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494343548434010,
"parent_rev": "3965ba442d09131dd9e2e4fd576cddab672c4f29", "commit_rev":
"dc2e682ca5558e90332f8443e23539a04f436273"}

[commit-bot: I haz the power, 2017-05-09 18:39:52]

Description was changed from

==========
cros: Hook AppCurrentWindowInternal setActivateOnPointer with aura side api

Changes:
This is a follow up CL of https://codereview.chromium.org/2809073002/, which
hooks AppCurrentWindowInternal setActivateOnPointer API with aura side changes.

BUG=657525
TEST=none
==========

to

==========
cros: Hook AppCurrentWindowInternal setActivateOnPointer with aura side api

Changes:
This is a follow up CL of https://codereview.chromium.org/2809073002/, which
hooks AppCurrentWindowInternal setActivateOnPointer API with aura side changes.

BUG=657525
TEST=none

Review-Url: https://codereview.chromium.org/2854893004
Cr-Commit-Position: refs/heads/master@{#470390}
Committed:
https://chromium.googlesource.com/chromium/src/+/dc2e682ca5558e90332f8443e235...
==========

[commit-bot: I haz the power, 2017-05-09 18:39:53]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/dc2e682ca5558e90332f8443e235...