Force URLs in omnibox suggestions to layout LTR.

Force URLs in omnibox suggestions to layout LTR.

This treats URLs the same way they are treated in the omnibox text field:
https://cs.chromium.org/chromium/src/ios/chrome/browser/ui/omnibox/omnibox_text_field_ios.mm?l=528&rcl=5bd9e2fd296b774e34d04cddfb09893525a79c04

BUG=712919
Review-Url: https://codereview.chromium.org/2854893002
Cr-Commit-Position: refs/heads/master@{#469029}
Committed: https://chromium.googlesource.com/chromium/src/+/902fe23a4f224a6b8b17769670943fd5f28e2f3b

[Justin Donnelly, 2017-05-02 14:04:08]

The CQ bit was checked by jdonnelly@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-02 14:04:25]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Justin Donnelly, 2017-05-02 14:06:34]

jdonnelly@chromium.org changed reviewers:
+ rohitrao@chromium.org

[commit-bot: I haz the power, 2017-05-02 14:14:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-02 14:14:32]

Dry run: This issue passed the CQ dry run.

[Justin Donnelly, 2017-05-03 16:10:30]

ping

[rohitrao (ping after 24h), 2017-05-03 16:19:37]

lgtm

If we haven't already, it would be useful to update the bug with a pointer to
the CL/bug where we fixed the omnibox text field, since that was very similar.

https://codereview.chromium.org/2854893002/diff/1/ios/chrome/browser/ui/omnib...
File ios/chrome/browser/ui/omnibox/truncating_attributed_label.h (right):

https://codereview.chromium.org/2854893002/diff/1/ios/chrome/browser/ui/omnib...
ios/chrome/browser/ui/omnibox/truncating_attributed_label.h:29:
@property(nonatomic, assign) BOOL displayAsURL;
Total nit: would something like "forceLTR" be a better name for this property? 
If we're in the UI layer, should we name things after high-level concepts like
"this is a URL", or should we name them after what they do, like "this forces
the text to display LTR"?

[Justin Donnelly, 2017-05-03 17:35:42]

On 2017/05/03 16:19:37, rohitrao (ping after 24h) wrote:
> lgtm
> 
> If we haven't already, it would be useful to update the bug with a pointer to
> the CL/bug where we fixed the omnibox text field, since that was very similar.

Yup, mgiuca included a reference to the text field fix in his original report
(comment #1 on http://crbug.com/712919).

[Justin Donnelly, 2017-05-03 17:35:53]

https://codereview.chromium.org/2854893002/diff/1/ios/chrome/browser/ui/omnib...
File ios/chrome/browser/ui/omnibox/truncating_attributed_label.h (right):

https://codereview.chromium.org/2854893002/diff/1/ios/chrome/browser/ui/omnib...
ios/chrome/browser/ui/omnibox/truncating_attributed_label.h:29:
@property(nonatomic, assign) BOOL displayAsURL;
On 2017/05/03 16:19:37, rohitrao (ping after 24h) wrote:
> Total nit: would something like "forceLTR" be a better name for this property?

> If we're in the UI layer, should we name things after high-level concepts like
> "this is a URL", or should we name them after what they do, like "this forces
> the text to display LTR"?

Your suggestion makes sense but I'm interested in moving the blue text styling
for URLs into this class as well so I chose the more semantic name.

[Justin Donnelly, 2017-05-03 17:36:01]

The CQ bit was checked by jdonnelly@chromium.org

[commit-bot: I haz the power, 2017-05-03 17:36:29]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 17:50:50]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493832961661150, "parent_rev":
"514b12b4a862c921f3ec4732c484d03cc4c3155d", "commit_rev":
"902fe23a4f224a6b8b17769670943fd5f28e2f3b"}

[commit-bot: I haz the power, 2017-05-03 17:50:59]

Description was changed from

==========
Force URLs in omnibox suggestions to layout LTR.

This treats URLs the same way they are treated in the omnibox text field:
https://cs.chromium.org/chromium/src/ios/chrome/browser/ui/omnibox/omnibox_te...

BUG=712919
==========

to

==========
Force URLs in omnibox suggestions to layout LTR.

This treats URLs the same way they are treated in the omnibox text field:
https://cs.chromium.org/chromium/src/ios/chrome/browser/ui/omnibox/omnibox_te...

BUG=712919

Review-Url: https://codereview.chromium.org/2854893002
Cr-Commit-Position: refs/heads/master@{#469029}
Committed:
https://chromium.googlesource.com/chromium/src/+/902fe23a4f224a6b8b1776967094...
==========

[commit-bot: I haz the power, 2017-05-03 17:51:00]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/902fe23a4f224a6b8b1776967094...