Make chrome://net-export/ look better on Mac.

Make chrome://net-export/ look better on Mac.

In particular the min-height on buttons wasn't working.

BUG=701033
Review-Url: https://codereview.chromium.org/2854863003
Cr-Commit-Position: refs/heads/master@{#468995}
Committed: https://chromium.googlesource.com/chromium/src/+/ec320021c2dfb503b1b953e834414d1c0c49b375

[eroman, 2017-05-02 23:42:20]

eroman@chromium.org changed reviewers:
+ xunjieli@chromium.org

[eroman, 2017-05-02 23:42:20]

There is a bug in that the CSS "min-height" (and min-width for that matter)
don't work on <button> elements on Mac, when the control includes "border-color:
buttonface".

This was causing the buttons on net-export on Mac to look quite different from
other platforms.

I worked around this by using padding instead of min-height, which I think is a
better approach anyway.

Here is the before and after:

  http://imgur.com/a/go3Yy
  http://imgur.com/a/dgUsV

I tested on Linux and Windows. and the button size is (virtually) unchanged.

[eroman, 2017-05-02 23:44:10]

The CQ bit was checked by eroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-02 23:44:39]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 23:54:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-02 23:54:36]

Dry run: This issue passed the CQ dry run.

[xunjieli, 2017-05-03 13:26:58]

On 2017/05/02 23:42:20, eroman wrote:
> There is a bug in that the CSS "min-height" (and min-width for that matter)
> don't work on <button> elements on Mac, when the control includes
"border-color:
> buttonface".
> 
> This was causing the buttons on net-export on Mac to look quite different from
> other platforms.
> 
> I worked around this by using padding instead of min-height, which I think is
a
> better approach anyway.
> 
> Here is the before and after:
> 
>   http://imgur.com/a/go3Yy
>   http://imgur.com/a/dgUsV
> 
> I tested on Linux and Windows. and the button size is (virtually) unchanged.

lgtm. Thanks for the context! I agree the new one looks better.

[eroman, 2017-05-03 16:07:26]

The CQ bit was checked by eroman@chromium.org

[commit-bot: I haz the power, 2017-05-03 16:08:00]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 16:12:25]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493827646113960, "parent_rev":
"424c0450bb5edc552aa13da3b8e7a9176cba70fc", "commit_rev":
"ec320021c2dfb503b1b953e834414d1c0c49b375"}

[commit-bot: I haz the power, 2017-05-03 16:12:35]

Description was changed from

==========
Make chrome://net-export/ look better on Mac.

In particular the min-height on buttons wasn't working.

BUG=701033
==========

to

==========
Make chrome://net-export/ look better on Mac.

In particular the min-height on buttons wasn't working.

BUG=701033

Review-Url: https://codereview.chromium.org/2854863003
Cr-Commit-Position: refs/heads/master@{#468995}
Committed:
https://chromium.googlesource.com/chromium/src/+/ec320021c2dfb503b1b953e83441...
==========

[commit-bot: I haz the power, 2017-05-03 16:12:36]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ec320021c2dfb503b1b953e83441...