Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 2854853004: [DevTools] Check location for null when creating EventListener (Closed)

Created:
3 years, 7 months ago by dgozman
Modified:
3 years, 7 months ago
Reviewers:
kozy
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Check location for null when creating EventListener BUG=700876 Review-Url: https://codereview.chromium.org/2854853004 Cr-Commit-Position: refs/heads/master@{#468814} Committed: https://chromium.googlesource.com/chromium/src/+/81ccbcd9c5b6de950869d165794b7072a6ee7769

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M third_party/WebKit/Source/devtools/front_end/sdk/DOMDebuggerModel.js View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
dgozman
Could you please take a look?
3 years, 7 months ago (2017-05-02 21:53:32 UTC) #2
kozy
lgtm
3 years, 7 months ago (2017-05-02 21:57:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2854853004/1
3 years, 7 months ago (2017-05-02 21:57:49 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 23:33:33 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/81ccbcd9c5b6de950869d165794b...

Powered by Google App Engine
This is Rietveld 408576698