Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 2854853003: MD Settings: Fix sync page layout after removing iron-flex-layout.html usage. (Closed)

Created:
3 years, 7 months ago by dpapad
Modified:
3 years, 7 months ago
Reviewers:
hcarmona
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Fix sync page layout after removing iron-flex-layout.html usage. BUG=717407 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2854853003 Cr-Commit-Position: refs/heads/master@{#468711} Committed: https://chromium.googlesource.com/chromium/src/+/ea2deba79c72cbf4bbe74b2f1783d33fdfbbd96b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/resources/settings/people_page/sync_page.html View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
dpapad
Before/after screenshots at http://imgur.com/a/Zm9OM.
3 years, 7 months ago (2017-05-02 17:31:07 UTC) #5
hcarmona
lgtm
3 years, 7 months ago (2017-05-02 18:03:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2854853003/1
3 years, 7 months ago (2017-05-02 18:11:58 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 18:40:10 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ea2deba79c72cbf4bbe74b2f1783...

Powered by Google App Engine
This is Rietveld 408576698