Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 2854823003: [Chromedriver] Fix stack overflow in JavaScript code (Closed)

Created:
3 years, 7 months ago by johnchen
Modified:
3 years, 7 months ago
Reviewers:
stgao
CC:
chromium-reviews, johnchen+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromedriver] Fix stack overflow in JavaScript code Multiple users have reported stack overflow errors in JavaScript code used by ChromeDriver. This is generally triggered by web pages that modify built-in types. In particular, adding named properties to Array prototype has been very problematic. This CL handles this issue by ignoring named properties in arrays. BUG=chromedriver:1114 Review-Url: https://codereview.chromium.org/2854823003 Cr-Commit-Position: refs/heads/master@{#469155} Committed: https://chromium.googlesource.com/chromium/src/+/550f56c09c04dc7d09f958d41e832d3c94069978

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -6 lines) Patch
M chrome/test/chromedriver/js/call_function.js View 2 chunks +20 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
johnchen
Shuotao: PTAL
3 years, 7 months ago (2017-05-03 02:27:08 UTC) #2
stgao
lgtm
3 years, 7 months ago (2017-05-03 20:14:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2854823003/1
3 years, 7 months ago (2017-05-03 21:46:03 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 22:06:36 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/550f56c09c04dc7d09f958d41e83...

Powered by Google App Engine
This is Rietveld 408576698