Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2854783002:
Re-land: Trigger linux_layout_tests_layout_ng for LayoutNG changes (Closed)
DescriptionRe-land: Trigger linux_layout_tests_layout_ng for LayoutNG changes
This is a re-land of r463177, after 23k lines were added to:
LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
Change PRESUBMIT.py for third_party/WebKit to trigger the LayoutNG test
bot, linux_layout_tests_layout_ng, which runs all layout tests with NG.
R=thakis@chromium.org, eae@chromium.org, glebl@chromium.org
BUG=706183, 714203
Review-Url: https://codereview.chromium.org/2854783002
Cr-Commit-Position: refs/heads/master@{#471625}
Committed: https://chromium.googlesource.com/chromium/src/+/6e27c23b503ebc4cef57d104f40950aae9dc1bcc
Patch Set 1 #
Messages
Total messages: 19 (12 generated)
The CQ bit was checked by kojii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
PTAL. Sent a notice to layout-dev@.
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM pending layout-dev discussion
Lgtm under same constraints too if you need it for owners.
Description was changed from ========== Re-land: Trigger linux_layout_tests_layout_ng for LayoutNG changes This is a re-land of r463177, after 23k lines were added to: LayoutTests/FlagExpectations/enable-blink-features=LayoutNG Change PRESUBMIT.py for third_party/WebKit to trigger the LayoutNG test bot, linux_layout_tests_layout_ng, which runs all layout tests with NG. R=thakis@chromium.org, eae@chromium.org, glebl@chromium.org BUG=706183 ========== to ========== Re-land: Trigger linux_layout_tests_layout_ng for LayoutNG changes This is a re-land of r463177, after 23k lines were added to: LayoutTests/FlagExpectations/enable-blink-features=LayoutNG Change PRESUBMIT.py for third_party/WebKit to trigger the LayoutNG test bot, linux_layout_tests_layout_ng, which runs all layout tests with NG. R=thakis@chromium.org, eae@chromium.org, glebl@chromium.org BUG=706183, 714203 ==========
The CQ bit was checked by kojii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
No objections so far: https://groups.google.com/a/chromium.org/d/msg/layout-dev/0G9FEFqONHU/19VY4u9... There's a risk of the bot starts failing when a large set of crashing/timeout tests (>= 100) is added. How to fix this is being discussed in crbug.com/714203, but infra saying it's not easy, and a workaround is as simple as to remove "CQ_INCLUDE_TRYBOTS" line in the description, until I update the FlagExpectations. So I consider the benefit wins over the problem. If we can find solution to crbug.com/714203, it's even greater.
The CQ bit was checked by kojii@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1494736908561490, "parent_rev":
"3eda6b165d26b7cc5e4549575780ddfe10502d62", "commit_rev":
"6e27c23b503ebc4cef57d104f40950aae9dc1bcc"}
Message was sent while issue was closed.
Description was changed from ========== Re-land: Trigger linux_layout_tests_layout_ng for LayoutNG changes This is a re-land of r463177, after 23k lines were added to: LayoutTests/FlagExpectations/enable-blink-features=LayoutNG Change PRESUBMIT.py for third_party/WebKit to trigger the LayoutNG test bot, linux_layout_tests_layout_ng, which runs all layout tests with NG. R=thakis@chromium.org, eae@chromium.org, glebl@chromium.org BUG=706183, 714203 ========== to ========== Re-land: Trigger linux_layout_tests_layout_ng for LayoutNG changes This is a re-land of r463177, after 23k lines were added to: LayoutTests/FlagExpectations/enable-blink-features=LayoutNG Change PRESUBMIT.py for third_party/WebKit to trigger the LayoutNG test bot, linux_layout_tests_layout_ng, which runs all layout tests with NG. R=thakis@chromium.org, eae@chromium.org, glebl@chromium.org BUG=706183, 714203 Review-Url: https://codereview.chromium.org/2854783002 Cr-Commit-Position: refs/heads/master@{#471625} Committed: https://chromium.googlesource.com/chromium/src/+/6e27c23b503ebc4cef57d104f409... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/6e27c23b503ebc4cef57d104f409... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
