Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 2854763002: Revert of Use new SafeBrowsing redirect tracking code in CWS pings. (Closed)

Created:
3 years, 7 months ago by sky
Modified:
3 years, 7 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use new SafeBrowsing redirect tracking code in CWS pings. (patchset #6 id:140001 of https://codereview.chromium.org/2779643002/ ) Reason for revert: Reverting in hopes of fixing 717315. See it for details. Original issue's description: > Use new SafeBrowsing redirect tracking code in CWS pings. > > The SafeBrowsing code tracks more types of redirects than the /net code which strictly adheres to spec and so can drop various types of redirects which can obscure the referrer chain. > > BUG=685905 > > Review-Url: https://codereview.chromium.org/2779643002 > Cr-Commit-Position: refs/heads/master@{#468389} > Committed: https://chromium.googlesource.com/chromium/src/+/39d1ffe7ba2c6fc8ebe6245472e0191b6f29aa9c TBR=jialiul@chromium.org,rdevlin.cronin@chromium.org,robertshield@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=685905 Review-Url: https://codereview.chromium.org/2854763002 Cr-Commit-Position: refs/heads/master@{#468495} Committed: https://chromium.googlesource.com/chromium/src/+/9fb1c8b9feec6f43c99eca8cecf09a5582c254f7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -132 lines) Patch
M chrome/browser/extensions/webstore_inline_installer.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/extensions/webstore_inline_installer.cc View 4 chunks +21 lines, -75 lines 0 comments Download
M chrome/browser/extensions/webstore_inline_installer_browsertest.cc View 9 chunks +10 lines, -54 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
sky
Created Revert of Use new SafeBrowsing redirect tracking code in CWS pings.
3 years, 7 months ago (2017-05-01 23:56:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2854763002/1
3 years, 7 months ago (2017-05-01 23:56:40 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 23:57:20 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9fb1c8b9feec6f43c99eca8cecf0...

Powered by Google App Engine
This is Rietveld 408576698