Add parameter to issue URLs for querying a ChangeList of a Team Drive.

Add parameter to issue URLs for querying a ChangeList of a Team Drive.

After the Drive API supports Team Drive, each Team Drive can be queried
for its changes individually, in addition to the files owned by a user.
This is necessary to fetch change of files under Team Drive, especially
those created by another user.

TEST=google_apis_unittests --gtest_filter=DriveApiRequestsTest.*:DriveApiUrlGeneratorTest.*
BUG=715355
Review-Url: https://codereview.chromium.org/2854653004
Cr-Commit-Position: refs/heads/master@{#468600}
Committed: https://chromium.googlesource.com/chromium/src/+/e88c61071918fa4fb20bc803613160e1d6ac5081

[yamaguchi, 2017-05-02 07:00:51]

The CQ bit was checked by yamaguchi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-02 07:01:04]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yamaguchi, 2017-05-02 07:02:37]

The CQ bit was checked by yamaguchi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-02 07:02:53]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 07:55:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-02 07:55:01]

Dry run: This issue passed the CQ dry run.

[yamaguchi, 2017-05-02 08:07:59]

Description was changed from

==========
Add team_drive_id param to URL generator.

BUG=715355
==========

to

==========
Add parameter to issue URLs for querying a ChangeList of a Team Drive.

After the Drive API supports Team Drive, each Team Drive can be queried
for its changes individually, in addition to the files owned by a user.
This is necessary to fetch change of files under Team Drive, especially
those created by another user.

TEST=google_apis_unittests --gtest_filter=DriveApiRequestsTest.*
BUG=715355
==========

[yamaguchi, 2017-05-02 08:08:56]

yamaguchi@chromium.org changed reviewers:
+ hashimoto@chromium.org

[yamaguchi, 2017-05-02 08:08:57]

ptal

[hashimoto, 2017-05-02 08:15:25]

https://codereview.chromium.org/2854653004/diff/20001/google_apis/drive/drive...
File google_apis/drive/drive_api_requests.cc (right):

https://codereview.chromium.org/2854653004/diff/20001/google_apis/drive/drive...
google_apis/drive/drive_api_requests.cc:669: team_drive_id_("") {
This line is not needed.
std::string is initialized to be empty by default.

https://codereview.chromium.org/2854653004/diff/20001/google_apis/drive/drive...
File google_apis/drive/drive_api_requests.h (right):

https://codereview.chromium.org/2854653004/diff/20001/google_apis/drive/drive...
google_apis/drive/drive_api_requests.h:695: team_drive_id_ = team_drive_id_;
The right hand side should be team_drive_id.

[yamaguchi, 2017-05-02 08:57:02]

Description was changed from

==========
Add parameter to issue URLs for querying a ChangeList of a Team Drive.

After the Drive API supports Team Drive, each Team Drive can be queried
for its changes individually, in addition to the files owned by a user.
This is necessary to fetch change of files under Team Drive, especially
those created by another user.

TEST=google_apis_unittests --gtest_filter=DriveApiRequestsTest.*
BUG=715355
==========

to

==========
Add parameter to issue URLs for querying a ChangeList of a Team Drive.

After the Drive API supports Team Drive, each Team Drive can be queried
for its changes individually, in addition to the files owned by a user.
This is necessary to fetch change of files under Team Drive, especially
those created by another user.

TEST=google_apis_unittests
--gtest_filter=DriveApiRequestsTest.*:DriveApiUrlGeneratorTest.*
BUG=715355
==========

[yamaguchi, 2017-05-02 08:57:16]

https://codereview.chromium.org/2854653004/diff/20001/google_apis/drive/drive...
File google_apis/drive/drive_api_requests.cc (right):

https://codereview.chromium.org/2854653004/diff/20001/google_apis/drive/drive...
google_apis/drive/drive_api_requests.cc:669: team_drive_id_("") {
On 2017/05/02 08:15:24, hashimoto wrote:
> This line is not needed.
> std::string is initialized to be empty by default.

Done.

https://codereview.chromium.org/2854653004/diff/20001/google_apis/drive/drive...
File google_apis/drive/drive_api_requests.h (right):

https://codereview.chromium.org/2854653004/diff/20001/google_apis/drive/drive...
google_apis/drive/drive_api_requests.h:695: team_drive_id_ = team_drive_id_;
On 2017/05/02 08:15:24, hashimoto wrote:
> The right hand side should be team_drive_id.

Done.
Also added unit test to cover this in drive_api_requests_unittest.cc.

[hashimoto, 2017-05-02 09:16:07]

lgtm

[yamaguchi, 2017-05-02 09:45:10]

The CQ bit was checked by yamaguchi@chromium.org

[commit-bot: I haz the power, 2017-05-02 09:45:30]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 09:53:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-02 09:53:16]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[yamaguchi, 2017-05-02 10:41:47]

The CQ bit was checked by yamaguchi@chromium.org

[yamaguchi, 2017-05-02 10:41:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
hashimoto@chromium.org
Link to the patchset: https://codereview.chromium.org/2854653004/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2017-05-02 10:42:06]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 11:37:33]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1493721707386820,
"parent_rev": "8829f12bd0eb33225c2a562fa1d5c9493aadd09a", "commit_rev":
"e88c61071918fa4fb20bc803613160e1d6ac5081"}

[commit-bot: I haz the power, 2017-05-02 11:37:40]

Description was changed from

==========
Add parameter to issue URLs for querying a ChangeList of a Team Drive.

After the Drive API supports Team Drive, each Team Drive can be queried
for its changes individually, in addition to the files owned by a user.
This is necessary to fetch change of files under Team Drive, especially
those created by another user.

TEST=google_apis_unittests
--gtest_filter=DriveApiRequestsTest.*:DriveApiUrlGeneratorTest.*
BUG=715355
==========

to

==========
Add parameter to issue URLs for querying a ChangeList of a Team Drive.

After the Drive API supports Team Drive, each Team Drive can be queried
for its changes individually, in addition to the files owned by a user.
This is necessary to fetch change of files under Team Drive, especially
those created by another user.

TEST=google_apis_unittests
--gtest_filter=DriveApiRequestsTest.*:DriveApiUrlGeneratorTest.*
BUG=715355

Review-Url: https://codereview.chromium.org/2854653004
Cr-Commit-Position: refs/heads/master@{#468600}
Committed:
https://chromium.googlesource.com/chromium/src/+/e88c61071918fa4fb20bc8036131...
==========

[commit-bot: I haz the power, 2017-05-02 11:37:43]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/e88c61071918fa4fb20bc8036131...