Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 2854633002: Make tracing an embedded service (Closed)

Created:
3 years, 7 months ago by sky
Modified:
3 years, 7 months ago
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make tracing an embedded service This way we don't try to find tracing on disk, which as there is no data_dep is out of date. BUG=none TEST=none R=rockot@chromium.org Review-Url: https://codereview.chromium.org/2854633002 Cr-Commit-Position: refs/heads/master@{#468383} Committed: https://chromium.googlesource.com/chromium/src/+/ad45c465d9b17114cab2c0b91564b9ddb882dc00

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M chrome/app/mash/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/app/mash/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/mash/embedded_services.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/test/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
sky
3 years, 7 months ago (2017-05-01 16:33:09 UTC) #1
Ken Rockot(use gerrit already)
lgtm
3 years, 7 months ago (2017-05-01 16:37:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2854633002/1
3 years, 7 months ago (2017-05-01 19:13:38 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 19:18:22 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ad45c465d9b17114cab2c0b91564...

Powered by Google App Engine
This is Rietveld 408576698