Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2854553002: Forward BrowserAccessibilityWin::get_accHelp to the platform node. (Closed)

Created:
3 years, 7 months ago by dougt
Modified:
3 years, 7 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, dougt+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, je_julie
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Forward BrowserAccessibilityWin::get_accHelp to the platform node. BUG=703369 Review-Url: https://codereview.chromium.org/2854553002 Cr-Commit-Position: refs/heads/master@{#468420} Committed: https://chromium.googlesource.com/chromium/src/+/9451bd7ecb9c10fa982c98a67366b2390c9dcbd2

Patch Set 1 #

Total comments: 1

Patch Set 2 : Use macro instead of if test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M content/browser/accessibility/browser_accessibility_win.cc View 1 chunk +1 line, -4 lines 0 comments Download
M ui/accessibility/platform/ax_platform_node_win.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
dougt
3 years, 7 months ago (2017-04-30 06:14:33 UTC) #6
dmazzoni
lgtm https://codereview.chromium.org/2854553002/diff/1/ui/accessibility/platform/ax_platform_node_win.cc File ui/accessibility/platform/ax_platform_node_win.cc (right): https://codereview.chromium.org/2854553002/diff/1/ui/accessibility/platform/ax_platform_node_win.cc#newcode512 ui/accessibility/platform/ax_platform_node_win.cc:512: if (!help) Use COM_OBJECT_VALIDATE instead?
3 years, 7 months ago (2017-05-01 16:16:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2854553002/20001
3 years, 7 months ago (2017-05-01 19:55:13 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 21:38:41 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9451bd7ecb9c10fa982c98a67366...

Powered by Google App Engine
This is Rietveld 408576698