Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2854503002: [Android] Keep extracted secondary dex files when clearing data in tests. (Closed)

Created:
3 years, 7 months ago by jbudorick
Modified:
3 years, 7 months ago
Reviewers:
agrieve
CC:
chromium-reviews, danakj+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Keep extracted secondary dex files when clearing data in tests. BUG=716029 Review-Url: https://codereview.chromium.org/2854503002 Cr-Commit-Position: refs/heads/master@{#468356} Committed: https://chromium.googlesource.com/chromium/src/+/039ec1ad2eaec6f13bfdda8cb3ac5e5d8cdc32b3

Patch Set 1 #

Patch Set 2 : findbugs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -25 lines) Patch
M base/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M base/test/android/javatests/src/org/chromium/base/test/BaseChromiumRunnerCommon.java View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/android/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/android/javatests/src/org/chromium/chrome/test/util/ApplicationData.java View 3 chunks +20 lines, -22 lines 0 comments Download

Messages

Total messages: 22 (14 generated)
jbudorick
3 years, 7 months ago (2017-04-28 22:30:08 UTC) #2
jbudorick
putting this on the Monday morning radar
3 years, 7 months ago (2017-05-01 12:55:52 UTC) #11
agrieve
lgtm
3 years, 7 months ago (2017-05-01 14:16:03 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2854503002/20001
3 years, 7 months ago (2017-05-01 14:17:48 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/373796)
3 years, 7 months ago (2017-05-01 16:57:26 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2854503002/20001
3 years, 7 months ago (2017-05-01 17:28:45 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/039ec1ad2eaec6f13bfdda8cb3ac5e5d8cdc32b3
3 years, 7 months ago (2017-05-01 18:13:21 UTC) #21
jbudorick
3 years, 7 months ago (2017-05-01 22:31:50 UTC) #22
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2849323002/ by jbudorick@chromium.org.

The reason for reverting is: primary suspect for crbug.com/717267.

Powered by Google App Engine
This is Rietveld 408576698