Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineDetailsView.js

Issue 2854473002: Revert of DevTools: Show screenshots on the main flamechart (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/timeline/TimelineEventOverview.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @unrestricted 6 * @unrestricted
7 */ 7 */
8 Timeline.TimelineDetailsView = class extends UI.VBox { 8 Timeline.TimelineDetailsView = class extends UI.VBox {
9 /** 9 /**
10 * @param {!Array<!TimelineModel.TimelineModelFilter>} filters 10 * @param {!Array<!TimelineModel.TimelineModelFilter>} filters
(...skipping 104 matching lines...) Expand 10 before | Expand all | Expand 10 after
115 this._selection = selection; 115 this._selection = selection;
116 switch (this._selection.type()) { 116 switch (this._selection.type()) {
117 case Timeline.TimelineSelection.Type.TraceEvent: 117 case Timeline.TimelineSelection.Type.TraceEvent:
118 var event = /** @type {!SDK.TracingModel.Event} */ (this._selection.obje ct()); 118 var event = /** @type {!SDK.TracingModel.Event} */ (this._selection.obje ct());
119 Timeline.TimelineUIUtils.buildTraceEventDetails( 119 Timeline.TimelineUIUtils.buildTraceEventDetails(
120 event, this._model.timelineModel(), this._detailsLinkifier, true) 120 event, this._model.timelineModel(), this._detailsLinkifier, true)
121 .then(fragment => this._appendDetailsTabsForTraceEventAndShowDet ails(event, fragment)); 121 .then(fragment => this._appendDetailsTabsForTraceEventAndShowDet ails(event, fragment));
122 break; 122 break;
123 case Timeline.TimelineSelection.Type.Frame: 123 case Timeline.TimelineSelection.Type.Frame:
124 var frame = /** @type {!TimelineModel.TimelineFrame} */ (this._selection .object()); 124 var frame = /** @type {!TimelineModel.TimelineFrame} */ (this._selection .object());
125 var filmStripFrame = Timeline.TimelineUIUtils.filmStripModelFrame(this._ model.filmStripModel(), frame); 125 var screenshotTime = frame.idle ?
126 frame.startTime :
127 frame.endTime; // For idle frames, look at the state at the beginni ng of the frame.
128 var filmStripFrame = this._model.filmStripModel().frameByTimestamp(scree nshotTime);
129 if (filmStripFrame && filmStripFrame.timestamp - frame.endTime > 10)
130 filmStripFrame = null;
126 this._setContent(Timeline.TimelineUIUtils.generateDetailsContentForFrame (frame, filmStripFrame)); 131 this._setContent(Timeline.TimelineUIUtils.generateDetailsContentForFrame (frame, filmStripFrame));
127 if (frame.layerTree) { 132 if (frame.layerTree) {
128 var layersView = this._layersView(); 133 var layersView = this._layersView();
129 layersView.showLayerTree(frame.layerTree); 134 layersView.showLayerTree(frame.layerTree);
130 if (!this._tabbedPane.hasTab(Timeline.TimelineDetailsView.Tab.LayerVie wer)) 135 if (!this._tabbedPane.hasTab(Timeline.TimelineDetailsView.Tab.LayerVie wer))
131 this._appendTab(Timeline.TimelineDetailsView.Tab.LayerViewer, Common .UIString('Layers'), layersView); 136 this._appendTab(Timeline.TimelineDetailsView.Tab.LayerViewer, Common .UIString('Layers'), layersView);
132 } 137 }
133 break; 138 break;
134 case Timeline.TimelineSelection.Type.NetworkRequest: 139 case Timeline.TimelineSelection.Type.NetworkRequest:
135 var request = /** @type {!TimelineModel.TimelineModel.NetworkRequest} */ (this._selection.object()); 140 var request = /** @type {!TimelineModel.TimelineModel.NetworkRequest} */ (this._selection.object());
(...skipping 95 matching lines...) Expand 10 before | Expand all | Expand 10 after
231 * @enum {string} 236 * @enum {string}
232 */ 237 */
233 Timeline.TimelineDetailsView.Tab = { 238 Timeline.TimelineDetailsView.Tab = {
234 Details: 'Details', 239 Details: 'Details',
235 EventLog: 'EventLog', 240 EventLog: 'EventLog',
236 CallTree: 'CallTree', 241 CallTree: 'CallTree',
237 BottomUp: 'BottomUp', 242 BottomUp: 'BottomUp',
238 PaintProfiler: 'PaintProfiler', 243 PaintProfiler: 'PaintProfiler',
239 LayerViewer: 'LayerViewer' 244 LayerViewer: 'LayerViewer'
240 }; 245 };
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/timeline/TimelineEventOverview.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698