Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 2854443003: Cancel pending stream requests as soon as a QUIC session is closed (Closed)

Created:
3 years, 7 months ago by Ryan Hamilton
Modified:
3 years, 7 months ago
Reviewers:
Jana
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Cancel pending stream requests as soon as a QUIC session is closed instead of waiting for it be be destroyed. Add tests for the cases where a connection is close before a StreamRequest completes (both sync and async). BUG=716563 Review-Url: https://codereview.chromium.org/2854443003 Cr-Commit-Position: refs/heads/master@{#468216} Committed: https://chromium.googlesource.com/chromium/src/+/94c26d6895a4e7db8b276d79189cab14dee4cc6a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -9 lines) Patch
M net/quic/chromium/quic_chromium_client_session.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/chromium/quic_chromium_client_session.cc View 3 chunks +13 lines, -9 lines 0 comments Download
M net/quic/chromium/quic_chromium_client_session_test.cc View 1 chunk +58 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Ryan Hamilton
3 years, 7 months ago (2017-04-28 20:05:58 UTC) #2
Jana
lgtm
3 years, 7 months ago (2017-04-29 00:01:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2854443003/1
3 years, 7 months ago (2017-04-29 01:42:41 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-04-29 02:49:43 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/94c26d6895a4e7db8b276d79189c...

Powered by Google App Engine
This is Rietveld 408576698