Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2854413002:
Remove usage of bot_utils.GetDeviceAffinity in perf_data_generator (Closed)
DescriptionRemove usage of bot_utils.GetDeviceAffinity in perf_data_generator
|benchmark_sharding_map| is always non None, hence the branching to use
|bot_utils.GetDeviceAffinity| when it's None is now dead code.
BUG=713357
TBR=eyaich@chromium.org
Review-Url: https://codereview.chromium.org/2854413002
Cr-Commit-Position: refs/heads/master@{#469037}
Committed: https://chromium.googlesource.com/chromium/src/+/ce159dee32a6cf18669950198af0efd9218393e8
Patch Set 1 #Patch Set 2 : Fix testGenerateTelemetryTestsBlacklistedReferenceBuildTest #
Messages
Total messages: 24 (17 generated)
Description was changed from ========== Remove usage of bot_utils.GetDeviceAffinity in perf_data_generator This is dead code. BUG=713357 ========== to ========== Remove usage of bot_utils.GetDeviceAffinity in perf_data_generator |benchmark_sharding_map| is always non None, hence the branching to use |bot_utils.GetDeviceAffinity| when it's None is now dead code. BUG=713357 ==========
nednguyen@google.com changed reviewers: + ashleymarie@chromium.org, martiniss@chromium.org
The CQ bit was checked by nednguyen@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by nednguyen@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by nednguyen@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from ashleymarie@chromium.org Link to the patchset: https://codereview.chromium.org/2854413002/#ps20001 (title: "Fix testGenerateTelemetryTestsBlacklistedReferenceBuildTest")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
Description was changed from ========== Remove usage of bot_utils.GetDeviceAffinity in perf_data_generator |benchmark_sharding_map| is always non None, hence the branching to use |bot_utils.GetDeviceAffinity| when it's None is now dead code. BUG=713357 ========== to ========== Remove usage of bot_utils.GetDeviceAffinity in perf_data_generator |benchmark_sharding_map| is always non None, hence the branching to use |bot_utils.GetDeviceAffinity| when it's None is now dead code. BUG=713357 TBR=eyaich@chromium.org ==========
The CQ bit was checked by nednguyen@google.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493835160534940,
"parent_rev": "bc28b9160d36fd044d9dc669e6b7642715a21530", "commit_rev":
"ce159dee32a6cf18669950198af0efd9218393e8"}
Message was sent while issue was closed.
Description was changed from ========== Remove usage of bot_utils.GetDeviceAffinity in perf_data_generator |benchmark_sharding_map| is always non None, hence the branching to use |bot_utils.GetDeviceAffinity| when it's None is now dead code. BUG=713357 TBR=eyaich@chromium.org ========== to ========== Remove usage of bot_utils.GetDeviceAffinity in perf_data_generator |benchmark_sharding_map| is always non None, hence the branching to use |bot_utils.GetDeviceAffinity| when it's None is now dead code. BUG=713357 TBR=eyaich@chromium.org Review-Url: https://codereview.chromium.org/2854413002 Cr-Commit-Position: refs/heads/master@{#469037} Committed: https://chromium.googlesource.com/chromium/src/+/ce159dee32a6cf18669950198af0... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/ce159dee32a6cf18669950198af0... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
