Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Issue 2854363003: Remove confusing logic in QuicChromiumClientStream::Read (Closed)

Created:
3 years, 7 months ago by Ryan Hamilton
Modified:
3 years, 7 months ago
Reviewers:
Zhongyi Shi
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove confusing logic in QuicChromiumClientStream::Read Review-Url: https://codereview.chromium.org/2854363003 Cr-Commit-Position: refs/heads/master@{#469027} Committed: https://chromium.googlesource.com/chromium/src/+/03499255747e2689aac736e866ed3520e13df725

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M net/quic/chromium/quic_chromium_client_stream.cc View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Ryan Hamilton
3 years, 7 months ago (2017-05-03 14:13:28 UTC) #2
Zhongyi Shi
lgtm
3 years, 7 months ago (2017-05-03 16:28:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2854363003/1
3 years, 7 months ago (2017-05-03 16:28:48 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 17:44:51 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/03499255747e2689aac736e866ed...

Powered by Google App Engine
This is Rietveld 408576698