Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Issue 2854333002: Move StyleBoxData.h to a nested class in ComputedStyle. (Closed)

Created:
3 years, 7 months ago by shend
Modified:
3 years, 7 months ago
Reviewers:
meade_UTC10
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move StyleBoxData.h to a nested class in ComputedStyle. This patch removes StyleBoxData.h, moving its contents to a nested class inside ComputedStyle. BUG=628043 Review-Url: https://codereview.chromium.org/2854333002 Cr-Commit-Position: refs/heads/master@{#470916} Committed: https://chromium.googlesource.com/chromium/src/+/c16f9ff9695525a663e586c269685624e403d674

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -100 lines) Patch
M third_party/WebKit/Source/core/style/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 2 chunks +52 lines, -1 line 0 comments Download
D third_party/WebKit/Source/core/style/StyleBoxData.h View 1 chunk +0 lines, -98 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 20 (16 generated)
shend
Hi Eddy, PTAL. Bots are red because this deletes a file modified in parent patch.
3 years, 7 months ago (2017-05-08 22:20:15 UTC) #6
meade_UTC10
lgtm once the bots pass :p
3 years, 7 months ago (2017-05-09 05:16:09 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2854333002/20001
3 years, 7 months ago (2017-05-11 11:09:22 UTC) #17
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 11:14:18 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c16f9ff9695525a663e586c26968...

Powered by Google App Engine
This is Rietveld 408576698