Don't crash when having an update from an unknown identity

Don't crash when having an update from an unknown identity

In SyncSettingsCollectionViewController, the identity collection view might
not have been reloaded yet when identity updates arrive. Those event has
to be ignored to avoid crashes.

BUG=715590
Review-Url: https://codereview.chromium.org/2854303003
Cr-Commit-Position: refs/heads/master@{#468948}
Committed: https://chromium.googlesource.com/chromium/src/+/6dc8282045f5410911dffc071ff3c506d1c45c1b

[jlebel, 2017-05-03 09:57:41]

Patchset #1 (id:1) has been deleted

[jlebel, 2017-05-03 09:58:22]

jlebel@chromium.org changed reviewers:
+ lpromero@chromium.org

[jlebel, 2017-05-03 09:58:23]

Hello Louis,

Can you review this small patch?

Thanks,

[lpromero, 2017-05-03 10:05:57]

https://codereview.chromium.org/2854303003/diff/20001/ios/chrome/browser/ui/s...
File ios/chrome/browser/ui/settings/sync_settings_collection_view_controller.mm
(right):

https://codereview.chromium.org/2854303003/diff/20001/ios/chrome/browser/ui/s...
ios/chrome/browser/ui/settings/sync_settings_collection_view_controller.mm:967:
if (item) {
Isn't it "if (!item)"?

Please also change the description to remove the mention of table view (it's a
collection view) and the conjugaison in the last sentence.

[jlebel, 2017-05-03 11:03:57]

Description was changed from

==========
Don't crash when having an update from an unknown identity

In SyncSettingsCollectionViewController, the identity table view might
not have been reloaded yet when identity updates arrive. Those event has
to be ignored to avoid crashes.

BUG=715590
==========

to

==========
Don't crash when having an update from an unknown identity

In SyncSettingsCollectionViewController, the identity collection view might
not have been reloaded yet when identity updates arrive. Those event has
to be ignored to avoid crashes.

BUG=715590
==========

[jlebel, 2017-05-03 11:05:01]

Sorry about that.

https://codereview.chromium.org/2854303003/diff/20001/ios/chrome/browser/ui/s...
File ios/chrome/browser/ui/settings/sync_settings_collection_view_controller.mm
(right):

https://codereview.chromium.org/2854303003/diff/20001/ios/chrome/browser/ui/s...
ios/chrome/browser/ui/settings/sync_settings_collection_view_controller.mm:967:
if (item) {
On 2017/05/03 10:05:57, lpromero wrote:
> Isn't it "if (!item)"?
> 
> Please also change the description to remove the mention of table view (it's a
> collection view) and the conjugaison in the last sentence.

Done.

[lpromero, 2017-05-03 12:07:11]

lgtm

[jlebel, 2017-05-03 12:27:13]

The CQ bit was checked by jlebel@chromium.org

[commit-bot: I haz the power, 2017-05-03 12:27:34]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 12:39:25]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493814433427840,
"parent_rev": "3c59dc2e42600af652706acceefa6ef2d075c46d", "commit_rev":
"6dc8282045f5410911dffc071ff3c506d1c45c1b"}

[commit-bot: I haz the power, 2017-05-03 12:39:32]

Description was changed from

==========
Don't crash when having an update from an unknown identity

In SyncSettingsCollectionViewController, the identity collection view might
not have been reloaded yet when identity updates arrive. Those event has
to be ignored to avoid crashes.

BUG=715590
==========

to

==========
Don't crash when having an update from an unknown identity

In SyncSettingsCollectionViewController, the identity collection view might
not have been reloaded yet when identity updates arrive. Those event has
to be ignored to avoid crashes.

BUG=715590

Review-Url: https://codereview.chromium.org/2854303003
Cr-Commit-Position: refs/heads/master@{#468948}
Committed:
https://chromium.googlesource.com/chromium/src/+/6dc8282045f5410911dffc071ff3...
==========

[commit-bot: I haz the power, 2017-05-03 12:39:33]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/6dc8282045f5410911dffc071ff3...